[dev-v5] FluentMenu - Improve positioning and add mouseout handling for submenu closure - #5210
Merged
Denis Voituron (dvoituron) merged 2 commits intoAug 28, 2026
Conversation
…itioning fallbacks
Denis Voituron (dvoituron)
requested a review
from Vincent Baaij (vnbaaij)
as a code owner
August 28, 2026 18:53
Denis Voituron (dvoituron)
enabled auto-merge (squash)
August 28, 2026 18:53
Copilot started reviewing on behalf of
Denis Voituron (dvoituron)
August 28, 2026 18:53
View session
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.3%
Microsoft.FluentUI.AspNetCore.Components.Charts - 100%
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the FluentMenu v5 submenu UX by (1) closing open submenus when the pointer leaves and (2) adding positioning fallbacks intended to prevent submenus from covering their parent item when near viewport edges (issue #5207).
Changes:
- Added a
mouseouthandler in the menu script to close any open submenu when the pointer leaves its owning menu item (while preserving keyboard-focus behavior). - Added CSS
position-try-fallbacksfor submenu popovers to improve left/right/vertical fallback positioning.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Core/Components/Menu/FluentMenuList.razor.css | Adds positioning fallback rules for submenu <fluent-menu-list slot="submenu"> popovers. |
| src/Core.Scripts/src/Components/Menu/FluentMenu.ts | Adds a mouseout handler to close open submenus when the pointer leaves. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Vincent Baaij (vnbaaij)
approved these changes
Aug 28, 2026
Denis Voituron (dvoituron)
deleted the
users/dvoituron/dev-v5/fix-menu-right
branch
August 28, 2026 19:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[dev-v5] FluentMenu - Improve positioning and add mouseout handling for submenu closure
See #5207
peek_6.mp4
Unit Tests
Updated