[release-branch.go1.25] Upgrade openssl backend#2358
Merged
qmuntal merged 1 commit intoJun 10, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the vendored external crypto backends (notably github.com/microsoft/go-crypto-openssl) on the release-branch.go1.25 line to improve compatibility with OpenSSL 3.5 (including new EVP parameter APIs and FIPS-mode related behavior), intended to address microsoft/go issue #2322.
Changes:
- Bumps the
github.com/microsoft/go-crypto-openssldependency revision and refreshes the vendor patch content accordingly. - Adds/uses OpenSSL 3 EVP “*_ex2” / “set_params” entry points (e.g.,
EVP_CipherInit_ex2,EVP_PKEY_CTX_set_params) and introduces new OSSL_PARAM-based configuration in the backend. - Updates RSA-PSS configuration for OpenSSL 3 to use
EVP_PKEY_CTX_set_paramsand introduces a FIPS-related RSA-PSS salt-length check parameter.
Show a summary per file
| File | Description |
|---|---|
| patches/0001-Vendor-external-dependencies.patch | Updates the vendored dependency patch to a newer go-crypto-openssl revision and incorporates OpenSSL 3.5-related backend changes (cipher init params, RSA-PSS params, HKDF params, new shims/bindings). |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
gdams
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upgrade bring some OpenSSL 3.5 support improvements.
Fixes #2322.