Harden LVBS/HEKI module/kexec validation against TOCTOU and confused deputy#1011
Merged
Conversation
sangho2
changed the title
sangho2
force-pushed
the
sanghle/lvbs/modval
branch
4 times, most recently
from
July 8, 2026 05:25
0b150e2 to
c09c768
Compare
sangho2
changed the title
sangho2
force-pushed
the
sanghle/lvbs/modval
branch
4 times, most recently
from
July 8, 2026 22:49
a850ad1 to
392fd5a
Compare
sangho2
marked this pull request as ready for review
July 8, 2026 22:51
sangho2
force-pushed
the
sanghle/lvbs/modval
branch
2 times, most recently
from
July 11, 2026 03:27
991ac2f to
e1aa5f3
Compare
sangho2
added
the
must-not-merge:undergoing-restructuring
sangho2
changed the title
sangho2
marked this pull request as draft
July 13, 2026 17:40
sangho2
removed
the
must-not-merge:undergoing-restructuring
sangho2
force-pushed
the
sanghle/lvbs/modval
branch
3 times, most recently
from
July 13, 2026 23:42
d5efb4c to
2f40b72
Compare
sangho2
marked this pull request as ready for review
July 13, 2026 23:46
sangho2
added
the
must-not-merge:undergoing-restructuring
sangho2
marked this pull request as draft
July 14, 2026 15:07
sangho2
force-pushed
the
sanghle/lvbs/modval
branch
from
July 14, 2026 15:50
2f40b72 to
abcc741
Compare
sangho2
removed
the
must-not-merge:undergoing-restructuring
sangho2
marked this pull request as ready for review
July 14, 2026 15:51
sangho2
force-pushed
the
sanghle/lvbs/modval
branch
2 times, most recently
from
July 14, 2026 18:19
303382a to
d2ee660
Compare
wdcui
reviewed
Jul 15, 2026
wdcui
left a comment
wdcui
left a comment
Member
There was a problem hiding this comment.
I left some comments below. I don't have a high confidence of my review. Should we have someone else to take a look at this PR as well?
sangho2
force-pushed
the
sanghle/lvbs/modval
branch
from
July 16, 2026 19:57
743ca33 to
629b3f5
Compare
sangho2
force-pushed
the
sanghle/lvbs/modval
branch
2 times, most recently
from
July 16, 2026 21:52
a808c42 to
7f9455c
Compare
sangho2
force-pushed
the
sanghle/lvbs/modval
branch
from
July 17, 2026 16:50
7f9455c to
c1a1671
Compare
sangho2
force-pushed
the
sanghle/lvbs/modval
branch
from
July 17, 2026 17:05
c1a1671 to
47ff384
Compare
sangho2
enabled auto-merge
July 17, 2026 17:06
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardens LVBS/HEKI's module and kexec validation against TOCTOU and confused-deputy attacks. Currently, there is a time window which allows VTL0 (on another core) to tamper with validated module/kexec bytes before they turn into executable bytes, including direct modification and indirect modification through VTL1 (confused deputy). This PR eliminates this race condition by rejecting overlapped or already-protected page frames and freezing frames before copy/validation.