Fix runner tests that depend on executable guest paths#1016
Open
jaybosamiya-ms wants to merge 3 commits into
Open
Fix runner tests that depend on executable guest paths#1016jaybosamiya-ms wants to merge 3 commits into
jaybosamiya-ms wants to merge 3 commits into
Conversation
|
🤖 SemverChecks 🤖 No semver-relevant crate changes detected; skipped cargo-semver-checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python runner test previously skipped Python binaries with
$ORIGINdependencies (#479); this PR fixes it by making the guest paths actually just use the program inside the tar at the correct location, and setting upLD_ORIGIN_PATHas a workaround towards not yet supporting/proc/self/exe. This enables Python tests to run on more machines (including what I use, via mise).Generalizing a bit more, this PR also removes the special
/out/bashfor the shebang (#790), by using an actual bash path in it.Since we're now defaulting to
--program-from-tar(which I believe to be the right move for most of the tests) also added a quick test of usage without it, just to maintain coverage of it.