build: pin workspace Rust toolchain to 1.95.0

[Sander Saares (sandersaares)]

[Copilot speaking]

Motivation

Workspace commands otherwise use each environment's active default Rust toolchain. Compiler and lint updates can therefore introduce findings unrelated to a pull request, as seen in #700, rather than providing reproducible results.

Changes

The workspace and RUST_LATEST select the exact Rust 1.95.0 release, matching the upstream version of the internal ms-prod-1.95 release toolchain. Cross-linked comments define the three-way alignment contract.

The toolchain refresh script treats the internal release channel as the source of truth: maintainers select that channel first, then the script updates both public pins to the latest upstream patch in the selected minor.

The internal release-template protection is delivered by ox-sdk PR 5587019, which must merge before this pull request.

[Copilot]

Pull request overview

Pins the workspace’s default Rust toolchain so local developer commands use a consistent compiler version, reducing “incidental” diagnostics caused by developer-machine toolchain drift and keeping results aligned with CI’s static-analysis toolchain selection.

Changes:

• Add rust-toolchain.toml to pin the workspace toolchain to Rust 1.96.1.
• Update constants.env commentary to indicate RUST_LATEST must match rust-toolchain.toml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
rust-toolchain.toml	Introduces a pinned workspace Rust toolchain channel (1.96.1).
constants.env	Updates toolchain documentation to keep RUST_LATEST synchronized with the pinned workspace toolchain.

---

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.

scripts/update_rust_toolchain.ps1:38

• $ToolchainChannelPattern only matches lines that start with channel at column 0. A valid rust-toolchain.toml could still indent the key (e.g. channel = "..."), in which case the script will fail to detect/update it and exit with an error. Consider allowing leading whitespace so the updater is resilient to harmless formatting changes.

$ToolchainChannelPattern = '(?m)^(channel[ \t]*=[ \t]*)"([^"]*)"'

scripts/update_rust_toolchain.ps1:265

• Writing rust-toolchain.toml with Set-Content but without -Encoding can produce a non-UTF8 file on Windows PowerShell (e.g. UTF-16LE), which may break rustup parsing of the toolchain file. Since this is a TOML config consumed by external tooling, it’s safer to write it explicitly as UTF-8 (as other scripts do for *.toml).

if ($toolchainNeedsUpdate) {
    $newToolchainContent = Update-RustToolchain -FilePath $ToolchainFile -Version $newStableVersion
    Set-Content -Path $ToolchainFile -Value $newToolchainContent -NoNewline
}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (9827a27) to head (3c3183c).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #701   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         559      560    +1     
  Lines       60826    60861   +35     
=======================================
+ Hits        60826    60861   +35     

Flag	Coverage Δ
linux	?
linux-arm	?
scheduled	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[martin-kolinek]

This will most likely break the internal release build

[Sander Saares (sandersaares)]

Good point. I will adjust the release pipeline accordingly, as well.

[Evgenii (Vaiz)]

this will cause issues with publising

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

scripts/update_rust_toolchain.ps1:207

• Get-InternalToolchainMinorVersion relies on the automatic $Matches variable after a -notmatch check. $Matches is global state and can be stale/overwritten by other regex operations, making the extracted minor version brittle. It’s safer to explicitly capture the match result (and this also makes it easy to tolerate quoted YAML values like value: "ms-prod-1.95").

        $versions += $Matches[1]

[Sander Saares (sandersaares)]

[Copilot speaking]

Addressed the suppressed review finding in commit 3c3183c. Get-InternalToolchainMinorVersion now stores an explicit Regex.Match result and reads its named minor group instead of relying on automatic $Matches state. The parser also accepts consistently quoted YAML channel values.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

[Adomas Bekeras (AdomasBekeras)]

ox-sdk might not be the name of the folder under a different worktree

[Sander Saares (sandersaares)]

Well, it's just an example. Or do you see the problem also in some non-example locations?

[martin-kolinek]

Rejecting this until it's clarified that this is the right approach. Most Rust libraries don't use rust-toolchain.toml file, we should be sure that it's desirable before we add it. We also should make sure that our internal build pipelines can handle it first.

[Pato Sandaña (psandana)]

DANGER: Remove this reference to internal repos!

[Pato Sandaña (psandana)]

DANGER: remove references to internal repo