Set USE_RGB444 for the samd51 hardware variant - #7660
Set USE_RGB444 for the samd51 hardware variant#7660Mikey Sklar (mikeysklar) wants to merge 2 commits into
Conversation
The ST7735 RGB444 path added in microsoft/pxt-common-packages#1627 is gated on #ifdef USE_RGB444, which nothing currently defines, so web builds still take the RGBSET path and render greyscale on newer PyBadge panels. Define the flag for the samd51 variant; screen.cpp already guards the path at runtime on Adafruit board ids, so non-Adafruit samd51 boards keep the stock path. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Hardware confirmed on a PyBadge (Board-ID SAMD51J19A-PyBadge-M4, bootloader v4.0.0).
Built the colorbar demo from microsoft/pxt-common-packages#1627 locally with the flag coming only from The define does reach
626688 matches the test UF2 attached to #1627 byte for byte in size, with 66 bytes differing in the build-hash region. One trap if anyone rebuilds this locally: the codal build does not recompile when only |

Follow-up to the pxt side of pxt-common-packages#1627.
That PR fixes greyscale rendering on newer PyBadge / PyBadge LC panels, and it is already live in common-packages 14.1.3 which this repo pinned in 181ee59. But the new path is gated on
#ifdef USE_RGB444and nothing defines that symbol, so it compiles out and arcade.makecode.com builds still take the RGBSET path. A user confirmed that today: comment.This defines the flag for
hw---samd51.screen.cppalready guards the path at runtime onCFG_BOOTLOADER_BOARD_ID, so the Kitronik boards that share this variant fall back to RGBSET.Richard Knoll (@riknoll) this is the flag you offered to wire up, let me know if it belongs somewhere else in the build.
Fixes #6861
🤖 Generated with Claude Code