[QRE] Build trace from Q# program#3421
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fedimser
requested review from
billti,
brad-lackey,
idavis,
minestarks,
msoeken and
swernli
as code owners
msoeken
left a comment
msoeken
left a comment
There was a problem hiding this comment.
Looks great! I left some initial comments for now.
|
|
||
| Some(Ok(Value::unit())) | ||
| } | ||
| "BeginEstimateCaching" => Some(Ok(Value::Bool(true))), |
There was a problem hiding this comment.
Are there plans to support this later?
There was a problem hiding this comment.
I didn't want to, because unlike with counts, caching trace fragment will not speed up resource estimaiton because size of trace is asymptotically the same as size of circuit. Am I wrong?
|
|
||
| Some(Ok(Value::unit())) | ||
| } | ||
| _ => None, |
There was a problem hiding this comment.
We should consider a way to reflect custom Q# intrinsics in the trace. This can be done in a separate PR though. The idea is that the user can define a custom intrinsic in Q# (e.g., a logical instruction supported by a specific QEC code) and then have it appear in the QRE trace.
There was a problem hiding this comment.
Will definitely do that, but need to think how to represent it, maybe not literally as Q# intrinsic?
3 participants
No description provided.