Include servicing kind in gRPC completed message#613
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends Trident’s gRPC “servicing completed” response to include the kind of servicing operation that occurred, and plumbs that information from the engine layer through the server to the protobuf Completed message.
Changes:
- Add
servicing_kindtotrident.v1.Completedand define a newServicingKindenum in the v1 servicing proto. - Thread servicing kind through the server’s servicing task plumbing and gRPC handlers so successful responses can include it.
- Update core
Trident/engine APIs to returnServicingTypealongsideExitKind(and hash where applicable), enabling the server to report the kind.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| proto/trident/v1/servicing.proto | Adds Completed.servicing_kind and defines the ServicingKind enum. |
| crates/trident/src/server/tridentserver/servicingmgr.rs | Extends servicing task result tuple and populates Completed.servicing_kind. |
| crates/trident/src/server/tridentserver/services/mod.rs | Adds servicing_type_to_kind mapping from internal ServicingType to proto ServicingKind. |
| crates/trident/src/server/tridentserver/services/update.rs | Converts returned ServicingType into ServicingKind for streaming responses. |
| crates/trident/src/server/tridentserver/services/install.rs | Converts returned ServicingType into ServicingKind for streaming responses. |
| crates/trident/src/server/tridentserver/services/streaming.rs | Converts returned ServicingType into ServicingKind for streaming responses. |
| crates/trident/src/server/tridentserver/services/commit.rs | Adapts to commit() returning ServicingType and reports kind in response tuple. |
| crates/trident/src/server/tridentserver/services/rebuild_raid.rs | Updates servicing task tuple shape (no servicing kind reported). |
| crates/trident/src/server/tridentserver/mod.rs | Updates servicing request closure signature to include optional servicing kind. |
| crates/trident/src/main.rs | Adapts CLI path to updated return types (including new servicing type values). |
| crates/trident/src/lib.rs | Updates install/update/stream_image/commit APIs to return ServicingType (and uses it in commit). |
| crates/trident/src/engine/update.rs | Updates engine update flow to return (ExitKind, ServicingType) and propagate servicing type. |
Contributor
|
nit: bump trident-proto version |
frhuelsz
reviewed
Apr 17, 2026
frhuelsz
reviewed
Apr 17, 2026
Contributor
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.