Skip to content

Include servicing kind in gRPC completed message#613

Open
fintelia wants to merge 5 commits intomainfrom
user/jbehrens/commit-kind
Open

Include servicing kind in gRPC completed message#613
fintelia wants to merge 5 commits intomainfrom
user/jbehrens/commit-kind

Conversation

@fintelia
Copy link
Copy Markdown
Contributor

No description provided.

@fintelia fintelia requested a review from a team as a code owner April 17, 2026 18:45
Copilot AI review requested due to automatic review settings April 17, 2026 18:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends Trident’s gRPC “servicing completed” response to include the kind of servicing operation that occurred, and plumbs that information from the engine layer through the server to the protobuf Completed message.

Changes:

  • Add servicing_kind to trident.v1.Completed and define a new ServicingKind enum in the v1 servicing proto.
  • Thread servicing kind through the server’s servicing task plumbing and gRPC handlers so successful responses can include it.
  • Update core Trident/engine APIs to return ServicingType alongside ExitKind (and hash where applicable), enabling the server to report the kind.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
proto/trident/v1/servicing.proto Adds Completed.servicing_kind and defines the ServicingKind enum.
crates/trident/src/server/tridentserver/servicingmgr.rs Extends servicing task result tuple and populates Completed.servicing_kind.
crates/trident/src/server/tridentserver/services/mod.rs Adds servicing_type_to_kind mapping from internal ServicingType to proto ServicingKind.
crates/trident/src/server/tridentserver/services/update.rs Converts returned ServicingType into ServicingKind for streaming responses.
crates/trident/src/server/tridentserver/services/install.rs Converts returned ServicingType into ServicingKind for streaming responses.
crates/trident/src/server/tridentserver/services/streaming.rs Converts returned ServicingType into ServicingKind for streaming responses.
crates/trident/src/server/tridentserver/services/commit.rs Adapts to commit() returning ServicingType and reports kind in response tuple.
crates/trident/src/server/tridentserver/services/rebuild_raid.rs Updates servicing task tuple shape (no servicing kind reported).
crates/trident/src/server/tridentserver/mod.rs Updates servicing request closure signature to include optional servicing kind.
crates/trident/src/main.rs Adapts CLI path to updated return types (including new servicing type values).
crates/trident/src/lib.rs Updates install/update/stream_image/commit APIs to return ServicingType (and uses it in commit).
crates/trident/src/engine/update.rs Updates engine update flow to return (ExitKind, ServicingType) and propagate servicing type.

Comment thread crates/trident/src/server/tridentserver/servicingmgr.rs
@frhuelsz
Copy link
Copy Markdown
Contributor

nit: bump trident-proto version

Comment thread crates/trident/src/server/tridentserver/services/mod.rs Outdated
Comment thread crates/trident/src/server/tridentserver/servicingmgr.rs Outdated
Copilot AI review requested due to automatic review settings April 17, 2026 22:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.

Comment thread crates/trident/src/server/tridentserver/services/install.rs Outdated
Comment thread crates/trident/src/server/tridentserver/services/install.rs Outdated
Comment thread crates/trident/src/server/tridentserver/services/install.rs Outdated
@fintelia
Copy link
Copy Markdown
Contributor Author

/AzurePipelines run [GITHUB]-trident-pr-e2e

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants