Fix attestation commit in webview view#8839
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes approval-with-attestation behavior when approving from the webview’s dropdown/context menu by threading the addAttestation flag through the webview context and ensuring the approve command path can create/push the attestation commit and splice the resulting timeline event without a full refresh.
Changes:
- Include
addAttestationin the webview context used by the review submit dropdown/context menu. - Extend review context/command argument types to optionally carry
addAttestation. - Update approve command handlers (overview panel + active PR view) to optionally create an attestation commit and pass through additional timeline events.
Show a summary per file
| File | Description |
|---|---|
| webviews/components/comment.tsx | Adds addAttestation into the data-vscode-context payload for the review dropdown/context menu. |
| src/github/views.ts | Extends ReviewCommentContext with optional addAttestation to support passing the flag through context-menu commands. |
| src/github/pullRequestOverview.ts | Updates overview-panel approve command path to optionally create an attestation commit and forward additional timeline events. |
| src/github/activityBarViewProvider.ts | Updates active PR view approve command path to optionally create an attestation commit and forward additional timeline events. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Low
alexr00
disabled auto-merge
July 13, 2026 14:48
roblourens
approved these changes
Jul 13, 2026
Comment on lines
629
to
631
| <ContextDropdown | ||
| optionsContext={() => makeCommentMenuContext(owner, repo, number, availableActions, pendingCommentText, shouldDisableNonApproveButtons)} | ||
| optionsContext={() => makeCommentMenuContext(owner, repo, number, availableActions, pendingCommentText, shouldDisableNonApproveButtons, addAttestation)} | ||
| defaultAction={defaultSubmitAction} |
Comment on lines
808
to
810
| <ContextDropdown | ||
| optionsContext={() => makeCommentMenuContext(pr.owner, pr.repo, pr.number, availableActions, pr.pendingCommentText, shouldDisableNonApproveButtons)} | ||
| optionsContext={() => makeCommentMenuContext(pr.owner, pr.repo, pr.number, availableActions, pr.pendingCommentText, shouldDisableNonApproveButtons, addAttestation)} | ||
| defaultAction={defaultSubmitAction} |
Comment on lines
+988
to
+994
| private async approvePullRequestCommand(context: SubmitReviewArgs): Promise<void> { | ||
| const result = context.addAttestation | ||
| ? await addAttestationCommit(this._folderRepositoryManager, this._item) | ||
| : undefined; | ||
| if (context.addAttestation && !result) { | ||
| return; | ||
| } |
Comment on lines
+409
to
+415
| private async approvePullRequestCommand(context: SubmitReviewArgs): Promise<void> { | ||
| const result = context.addAttestation | ||
| ? await addAttestationCommit(this._folderRepositoryManager, this._item) | ||
| : undefined; | ||
| if (context.addAttestation && !result) { | ||
| return; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.