Try to fix focus view showing on git commands#8842
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the “focused review mode” reveal behavior so that a deferred “show the PR” request is consumed only once, reducing unintended repeated reveals (e.g., when triggered around git commands).
Changes:
- Convert the
ShowPullRequest“should show” flag into a one-shot value viatakeShouldShow()(read-and-reset). - Update
ReviewManager.layout()to use the one-shot value and to guard against multiple listener firings triggering repeated reveals. - Add a unit test to ensure a deferred reveal only happens once.
Show a summary per file
| File | Description |
|---|---|
src/view/reviewManager.ts |
Consumes the deferred “show PR” signal via takeShouldShow() so it doesn’t repeatedly trigger focus reveals. |
src/test/view/reviewManager.test.ts |
Adds coverage asserting a deferred focused reveal triggers only once across repeated layout() calls. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Low
chrmarti
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.