Skip to content

chore: bump glob from 7.1.6 to 13.0.6#8850

Draft
rzhao271 with Copilot wants to merge 3 commits into
mainfrom
copilot/bump-glob-to-latest-version
Draft

chore: bump glob from 7.1.6 to 13.0.6#8850
rzhao271 with Copilot wants to merge 3 commits into
mainfrom
copilot/bump-glob-to-latest-version

Conversation

Copilot AI commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Upgrades glob from v7 to v13 (latest). glob v9+ bundles its own types, so @types/glob is removed. glob v13 also drops the default export, requiring a fix to the one import in the codebase.

Changes

  • package.json: glob 7.1.613.0.6; drop @types/glob
  • src/test/index.ts: Default import → namespace import; glob.sync() remains available as a named export
// Before
import glob from 'glob';

// After
import * as glob from 'glob';

- Upgrade glob devDependency from 7.1.6 to 13.0.6
- Remove @types/glob (types are now bundled with glob v9+)
- Fix import in src/test/index.ts: default import → namespace import
  (glob v13 has no default export)
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@rzhao271 rzhao271 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Remove the new yarn lock file and update whichever lockfile existed before instead.

@rzhao271 rzhao271 added this to the 1.130.0 milestone Jul 15, 2026
Used npm install instead of yarn to update the correct lockfile

Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>

Copilot AI commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Remove the new yarn lock file and update whichever lockfile existed before instead.

Done — removed yarn.lock and updated package-lock.json via npm install instead. Commit: chore: remove yarn.lock, update package-lock.json with glob 13.0.6.

Copilot AI requested a review from rzhao271 July 15, 2026 21:37

@rzhao271 rzhao271 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Fix tests

- Replace callback-based util.promisify(require('glob')) with the
  native promise-based named export { glob } from glob v13
- Add copyright header (required by hygiene)
- Fix whitespace indentation in usage template literal

Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>

Copilot AI commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Fix tests

scripts/preprocess-svg.js was using util.promisify(require('glob')) which breaks in glob v13 (the package no longer exports a callback-based function as its default export). Fixed by switching to the native promise-based { glob } named export. Also added the missing copyright header and fixed whitespace to pass the pre-commit hygiene check. Commit: fix: update preprocess-svg.js for glob v13 compatibility.

Copilot AI requested a review from rzhao271 July 15, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants