Fix version parsing logic - #208
Merged
Merged
Conversation
Contributor
Author
|
@JasonGross could you review this? Without it, rewrite doesn't build from scratch with rocq 9.2 |
Collaborator
|
Sorry, I missed this. This will break as soon as we get 9.10, is there something more robust we can do? |
Prefix patterns like 9.1% would match 9.10 the day it exists. Instead, normalize COQ_VERSION to its first two components (splitting on ".", "+", "-", "~", so "9.2", "9.2.0", "9.2+rc1" and "9.2.0+dfsg" all yield "9.2") and select the compat extension by exact equality on that. Unknown future versions (9.10, 9.3, dev) still fall through to the newest extension, as before. Verified against 9.2 / 9.2.0 / 9.2+rc1 / 9.2.0+dfsg -> .v92, 9.1 / 9.1.1 -> .v91, 9.0 -> .v90, 8.20.1 / 8.15 -> unchanged 8.x handling, and 9.10 / 9.10.0 / 9.10+rc1 / 9.3.0 / empty -> .v93. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019ttctspSoVoquHLQtbPVZw
JasonGross
enabled auto-merge (squash)
July 24, 2026 16:46
Contributor
Author
|
I see you fixed it already, thanks! |
JasonGross
disabled auto-merge
July 27, 2026 19:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old logic was not matching on versions with no third component.
This is hopefully the right way to parse these.