Validate SA3D channel map bounds - #1893
Merged
Merged
Conversation
Reject SA3D boxes whose declared channel map exceeds the box payload. Also validate extended sizes and avoid position arithmetic overflow so a crafted MP4 cannot force unbounded vector growth during metadata rewrite.
Member
|
Are you having fun driving your AI to spam projects? This code was copied from https://github.com/VarolOkan/spatial-media. Fix it there please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shotcut can exhaust memory when rewriting a crafted MP4 containing an SA3D
box with an oversized channel count.
SA3DBox::load trusted the declared channel count and appended that many channel
map entries without checking the box payload. This patch validates extended
box sizes, avoids overflowing position arithmetic, and requires the channel
map to fit within the box before parsing it.
Verification:
allocating unbounded memory.