Bound MP4 index table rewrites - #1894
Merged
ddennedy merged 1 commit intoAug 15, 2026
Merged
Conversation
Validate stco and co64 entry counts against the containing box before rewriting either table. Apply the same check to in-memory box contents so malformed media cannot drive unbounded output or reads.
Member
|
This code was copied from https://github.com/VarolOkan/spatial-media. Fix it there please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shotcut can generate unbounded output and consume CPU when rewriting a crafted
MP4 containing an stco or co64 box with an oversized entry count.
Box::index_copy trusted the declared table count and rewrote entries without
checking the containing box. This patch validates the table header and bounds
the declared count against the available payload for both file-backed and
in-memory box contents.
Verification: