Duck status - #1902
Merged
Merged
Conversation
The status set on the mix transition is earlier than the frame being displayed. Use the status from the frame so the status is synchronized with the preview player
Track audio level is calculated by the audio level filter before the mix transition ducking is applied. This change subtracts the track ducking gain reduction
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes how track “ducking” status is updated in the UI by moving from a polling timer to per-frame updates driven by SharedFrame metadata, and aligns track audio level metering with ducking reduction.
Changes:
- Replaces timer-based duck status refresh in
TrackPropertiesWidgetwithframeDisplayed(const SharedFrame&)-driven updates using per-frame metadata keys. - Publishes per-track duck level into frame metadata by setting a
prefixon each track’smixtransition. - Adjusts timeline track audio level metering to subtract the current ducking reduction so the UI reflects post-ducking levels.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/widgets/trackpropertieswidget.h | Adds SharedFrame slot and show/hide event overrides; replaces timer member with cached track index. |
| src/widgets/trackpropertieswidget.cpp | Hooks duck status updates to frameDisplayed and reads meta.track.<index>.duck_level from SharedFrame. |
| src/models/multitrackmodel.cpp | Sets mix transition prefix for duck metadata and subtracts duck reduction from displayed audio levels. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.