Add finalization-only cleanup gate for provisional scratch artifacts#314
Open
mmprotest wants to merge 1 commit into
Open
Add finalization-only cleanup gate for provisional scratch artifacts#314mmprotest wants to merge 1 commit into
mmprotest wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
_provisional_scratch_candidates,_explicit_mutation_created_paths, and_cleanup_summaryon theRunnerto track Bash-created files and explicit Write/Patch-created files.Bashinexecute_tool_with_lifecycleand adding newly-created files to the provisional set while recordingWrite/Patchcreated paths separately instate_tooling.py.cleanup_provisional_scratch_artifactsinstate_runtime.pythat conservatively filters eligible candidates (must be provenance-backed, regular file, inside repo, not explicit edits, not under source/test/pkg roots, root detection confident), backs them up, removes them, reruns existingrun_validation, and restores files on any failure/error._finish_boundedafterrun_post_execution_validationand before final summary write) and propagate cleanup telemetry intofinal_summary.jsonviaDebugRecorder.write_final_summarywithout adding a new telemetry system.tests/test_scratch_cleanup_gate.pycovering keep/restore, git untracked handling, exclusion of Write-created files, and source/tests exclusions.Testing
pytest -q tests/test_scratch_cleanup_gate.pyand all tests passed (4 passed).rg -n "cleanup_provisional_scratch_artifacts\(" villani_code, confirming the helper is invoked from exactly one final post-success location.Codex Task