[codex] Add Upload missing-file regression test#522
Draft
Conversation
Signed-off-by: Zhao Chen <winters.zc@antgroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uploadwhen the input file is missingUploadpreserves thegetProcessorstat failure introduced by fix: use InferFileType in getProcessor for unrecognized file extensions #499Why
#499changedUploadto surfacegetProcessorerrors, but the package only testedgetProcessordirectly. This leaves the publicUploadentrypoint unguarded against regressing back to the older generic error path.Validation
go test ./pkg/backend -run TestUploadMissingFileReturnsProcessorStatError -count=1go test ./pkg/backend -count=11c9e7ff^:go test ./pkg/backend -run TestUploadMissingFileReturnsProcessorStatError -count=1