[bugfix] fix GDN sequence_parallel not effective on LoraParallelLinear - #170
Closed
HowardZorn wants to merge 1 commit into
Closed
[bugfix] fix GDN sequence_parallel not effective on LoraParallelLinear#170HowardZorn wants to merge 1 commit into
HowardZorn wants to merge 1 commit into
Conversation
Author
|
Close as another PR has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #169.
Add a
sequence_parallelproperty onLoraParallelLinearthat delegates reads/writes tobase_layerand alllora_A/lora_Badapters, so_set_linear_sequence_parallel/_restore_linear_sequence_parallelinGatedDeltaNettake effect on LoRA-wrapped linears.Note: this works, but the approach feels a bit dirty (proxying inner modules' attribute via a property on the wrapper). Opened as a Draft PR — suggestions for a cleaner implementation are welcome.