Skip to content

fix: make Nemotron-H import error adaption on Megatron-Core 0.16.1 #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hjh0119 merged 2 commits into from
Aug 22, 2026
Merged

fix: make Nemotron-H import error adaption on Megatron-Core 0.16.1 #171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17111cb
fix: make Nemotron-H registration optional
hazelduan Aug 21, 2026
04e21c5
fix: localize Nemotron-H dependency guard
hazelduan Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions src/mcore_bridge/model/gpts/nemotron_h.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
import torch
from megatron.core.extensions.transformer_engine import TEColumnParallelLinear, TENorm, TERowParallelLinear
from megatron.core.fusions.fused_bias_dropout import get_bias_dropout_add
from megatron.core.models.hybrid.hybrid_block import HybridStack, HybridStackSubmodules
from megatron.core.models.hybrid.hybrid_layer_specs import hybrid_stack_spec
from megatron.core.ssm.mamba_layer import MambaLayer, MambaLayerSubmodules
from megatron.core.ssm.mamba_mixer import MambaMixer, MambaMixerSubmodules
from megatron.core.transformer.spec_utils import ModuleSpec
Expand All @@ -21,9 +19,21 @@
from mcore_bridge.utils import get_logger

from ..constant import ModelType
from ..hybrid_model import HybridModel
from ..register import ModelLoader, ModelMeta, register_model

try:
from megatron.core.models.hybrid.hybrid_block import HybridStack, HybridStackSubmodules
from megatron.core.models.hybrid.hybrid_layer_specs import hybrid_stack_spec

from ..hybrid_model import HybridModel

_HYBRID_MODEL_AVAILABLE = True
except ImportError as error:
if not (error.name or '').startswith('megatron.core.models.hybrid'):
raise
HybridModel = HybridStack = HybridStackSubmodules = hybrid_stack_spec = None
_HYBRID_MODEL_AVAILABLE = False

logger = get_logger()


Expand Down Expand Up @@ -410,9 +420,11 @@ def build_model(self, pre_process=True, post_process=True, vp_stage: Optional[in
return model


register_model(ModelMeta(
ModelType.nemotron_h,
['nemotron_h'],
bridge_cls=NemotronHBridge,
loader=NemotronHLoader,
))
if _HYBRID_MODEL_AVAILABLE:
register_model(
ModelMeta(
ModelType.nemotron_h,
['nemotron_h'],
bridge_cls=NemotronHBridge,
loader=NemotronHLoader,
))
Loading