fix(fxa-settings): prevent CJK button labels breaking one character per line - #21014
fix(fxa-settings): prevent CJK button labels breaking one character per line#21014vpomerleau wants to merge 1 commit into
Conversation
…er line Flex-shrink on settings row and modal CTA buttons was squeezing Japanese, Chinese, and Korean labels to a single character per line. Keep button text on one line and let paired modal actions wrap as a group when space is tight. Use child mx-2 margins for modal button spacing instead of gap-2 to avoid doubled horizontal spacing that caused premature wrapping. Fixes #18683
fa280e8 to
95ce9ff
Compare
|
Marked as draft, there are some issues with button layout and latin languages with long text strings. |
|
pushed a follow-up on #20724 for the latin layout — swapped checked the modal squeezed unit-row (the original cjk stacking). left is no keep-all, right is keep-all: modal pair in |


Because
This pull request
main; they remain the commit author..cta-xlnow usesgrow shrink-0 basis-0instead offlex-1, so labels are not compressed.shrink-0 whitespace-nowraprule for thecta-*variants, plus the same forcta-*insideunit-row-actions.flex-wrap) when horizontal space is tight.Issue that this pull request solves
Closes: #18683
Checklist
Put an
xin the boxes that applyScreenshots
Before

After

How to review (Optional)
packages/fxa-react/styles/ctas.css,packages/fxa-settings/src/styles/unit-row.css,Settings/Modal/index.tsx,Settings/SubRow/index.tsxcta-xlis used 58 times in fxa-settings and 11 call sites combine it withflex-1. The override relies on element+class specificity (button.cta-primary) beating theflex-1utility. Worth confirming English and German buttons still lay out correctly at mobile and landscape widths.Other information (Optional)
classNameonly. Manual CJK verification is still needed.tsc --noEmitclean, ESLint clean on both changed TSX files. One failure,Pair2/Supplicant/TimeoutAndCancel, reproduces identically on unmodifiedmainand is unrelated to this change.