feat: add Base64 image encoding - #177
Merged
Merged
Conversation
mrousavy
commented
Aug 25, 2026
Co-authored-by: Marc Rousavy <me@mrousavy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Image.toBase64Async(format, quality?)with a documented standard, padded Base64 contractUIImageandBitmapoff the caller thread, without an intermediate JSArrayBufferTests
bun run typecheckbun run lint-cicd packages/react-native-nitro-image && bun run buildcd packages/react-native-nitro-image && bun run specs./gradlew :react-native-nitro-image:compileDebugKotlin --no-daemon./gradlew app:assembleDebug -PreactNativeArchitectures=arm64-v8a --no-daemonNitroImagelibrary scheme build for the iPhone 17 Pro simulatorbun example test:harness __tests__/image-encoding.harness.ts --harnessRunner android-deviceon a physical Android device - 16 tests passedNotes
The iOS library target builds successfully. The local example app link is currently blocked by
framework React not foundbefore it can run, so iOS runtime harness coverage is left to CI.This adds a required method to
HybridImageSpec. Existing iOS types conforming throughNativeImagereceive the default implementation.Closes #174