Code cleanup from other PR

[mmathieum]

• Providers > + asyncOnly #161

[gemini-code-assist]

Code Review

This pull request refactors various status filters and providers, renaming copyWith to copyWithProvidedEncryptKeysMap, adding copyWithCacheOnly, and converting StatusProviderContract.Filter.from into an extension function on POI. It also applies minor cleanups like adding final modifiers and nullability annotations. A critical issue was identified in AgencyProviderDeployWorker where using first instead of firstOrNull will cause a NoSuchElementException crash if no matching provider is found, bypassing the Elvis operator.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[Copilot]

Pull request overview

This PR is a follow-up cleanup to prior provider/contract changes (referenced from #161), primarily standardizing small API helpers, nullability/immutability tweaks, and status/provider filter ergonomics.

Changes:

• Refactors provider/status filter construction and adds/renames filter “copyWith*” helpers (including cacheOnly support).
• Tightens nullability and local immutability (final), plus small Kotlin/Java cleanups (early returns, firstOrNull, return types).
• Removes POIProviderContract.Filter.addExtra(...) and adds a small POI filter extra extension accessor.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/main/java/org/mtransit/android/commons/task/MTCancellableAsyncTask.kt	Adds isCancelledMT accessor and uses early returns for cancellation checks.
src/main/java/org/mtransit/android/commons/provider/status/StatusProviderContract.kt	Refactors POI→status filter creation to an extension and updates Filter copy APIs.
src/main/java/org/mtransit/android/commons/provider/status/StatusProvider.java	Minor immutability cleanup (final int type).
src/main/java/org/mtransit/android/commons/provider/serviceupdate/ServiceUpdateProviderContract.kt	Adds copyWithCacheOnly(...) convenience.
src/main/java/org/mtransit/android/commons/provider/poi/POIProviderExtraExt.kt	Adds avoidLoadingOrDefault extra accessor extension.
src/main/java/org/mtransit/android/commons/provider/poi/POIProviderContract.kt	Removes addExtra(...) from POI filter.
src/main/java/org/mtransit/android/commons/provider/poi/POIProvider.java	Nullability annotations + minor refactors; introduces @CanIgnoreReturnValue.
src/main/java/org/mtransit/android/commons/provider/news/NewsProvider.java	Minor immutability cleanup (final locals).
src/main/java/org/mtransit/android/commons/provider/common/MTSearchRecentSuggestionsProvider.java	Comment wording cleanup.
src/main/java/org/mtransit/android/commons/provider/bike/BikeStationProvider.java	Minor immutability cleanup (final Cursor).
src/main/java/org/mtransit/android/commons/provider/agency/AgencyProviderDeployWorker.kt	Safer provider lookup (firstOrNull) and explicit Result return typing.
src/main/java/org/mtransit/android/commons/data/ScheduleStatusFilter.kt	Updates to new Status filter copy APIs (provided keys + cacheOnly).
src/main/java/org/mtransit/android/commons/data/POIStatus.java	Equivalent readability refactor of validity comparison.
src/main/java/org/mtransit/android/commons/data/News.java	Fixes Javadoc link to projection accessor.
src/main/java/org/mtransit/android/commons/data/AvailabilityPercentStatusFilter.kt	Updates to new Status filter copy APIs (provided keys + cacheOnly).
src/main/java/org/mtransit/android/commons/data/AvailabilityPercent.java	Minor immutability cleanup + condensed null handling.
src/main/java/org/mtransit/android/commons/data/AppStatusFilter.kt	Updates to new Status filter copy APIs (provided keys + cacheOnly).

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces several refactorings across data models and providers, including renaming copy methods, adding cache-only copy support, updating nullability annotations, and introducing a new extension property for POI filters. The review feedback highlights two key improvements: first, instead of removing the addExtra API in POIProviderContract.kt to avoid a crash, it is recommended to refactor the underlying extras map to a standard Kotlin MutableMap; second, the new avoidLoadingOrDefault extension property should be defined on a nullable Filter? receiver to simplify its usage across the codebase.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.