Skip to content

Filter cleanup: inFocus & maxValidity (& isUseful)#166

Draft
mmathieum wants to merge 3 commits into
masterfrom
mm/disable_clear_all_task_on_pause_leaving_screen
Draft

Filter cleanup: inFocus & maxValidity (& isUseful)#166
mmathieum wants to merge 3 commits into
masterfrom
mm/disable_clear_all_task_on_pause_leaving_screen

Conversation

@mmathieum

@mmathieum mmathieum commented Jul 1, 2026

Copy link
Copy Markdown
Member

@mmathieum

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the status tracking logic by replacing the negative boolean "noData" (and "isNoData()") with a positive boolean "hasData" (and "hasData()") across "POIStatus", "Schedule", and various transit providers. Additionally, "usefulUntilInMs" in "Schedule" has been renamed to "timestampsUntilInMs" along with its associated helper methods, and the unused "areUseful()" function in "ServiceUpdates" was removed. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant