Respect explicit reasoning config during GGUF thinking probe#9463
Merged
mudler merged 2 commits intoApr 21, 2026
Merged
Conversation
Signed-off-by: leinasi2014 <leinasi2014@gmail.com>
Contributor
Author
|
Thanks. I dug into the three failing checks and they do not appear to come from this reasoning-config fix.
The files touched by this PR are limited to:
So from what I can see, these CI failures are pre-existing / orthogonal to the change here, not regressions introduced by this PR. |
mudler
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reasoning.disableanddisable_reasoning_tag_prefillvalues during GGUF thinking probingProblem
reasoning.disableis an official LocalAI model config, but on the GGUF + tokenizer-template path the backend thinking probe could overwrite explicit YAML values after model load.There was also a related runtime gap: thinking probing only ran when both reasoning fields were nil, so partial explicit config could not preserve one field while inferring the other.
Fixes #9462.
Related context
This work is in the same broader reasoning/thinking area as:
Those items are related background, but this PR specifically fixes reasoning config precedence and probe gating.
Changes
core/config/gguf.go, only fill inferred reasoning values when the field is still unsetcore/backend/llm.go, probe when tokenizer templates are enabled and either reasoning field is unsetcore/config/gguf_reasoning_test.gocore/backend/llm_probe_test.goValidation
go test ./core/config ./core/backend ./pkg/reasoningconfig-jsonnow preserves explicit reasoning configmetadata.enable_thinking=falsenow produces the expected low-latency behavior at runtime