[scheduler] Make the event dialog General-tab building blocks public - #23398
Draft
rita-codes wants to merge 7 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRcxZwT2TmBBATNXwMEJUC
…eir theme classes Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRcxZwT2TmBBATNXwMEJUC
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRcxZwT2TmBBATNXwMEJUC
…d cover the recurring scopes Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRcxZwT2TmBBATNXwMEJUC
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRcxZwT2TmBBATNXwMEJUC
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRcxZwT2TmBBATNXwMEJUC
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRcxZwT2TmBBATNXwMEJUC
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
rita-codes
added
the
type: new feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22871. Part of #22866.
Third and final part of the General-tab slot work (follow-up to #23338): the export flip that makes the composition building blocks public.
Public surface
New
@mui/x-scheduler/event-dialogentry point (also re-exported from the package root):EventDialogGeneralTabContent— the default General-tab composition, usable from a custom slot to append content after the built-in sections.DateTimeSection,ResourceAndColorSection,DescriptionSection— the built-in sections, moved out ofinternals/and switched to named exports.SectionFieldset,SectionHeaderTitle— the layout primitives, now thin wrappers that self-apply their theme classes so custom sections look native without passingclassesexplicitly (premium'sRecurrenceTabdrops its duplicated styled copy).useEventDialogFormField— the form-field hook from [scheduler] Introduce the edit dialog form context & lifecycle contract #23284, plus its parameter/return types.useEventDialogOccurrence— new hook returning the occurrence being edited (reads the form store; the interim occurrence context was removed during [scheduler] Add theeventDialogGeneralTabslot #23338's review).TitleSection, the form store, and the form context stay internal.Tests
FormProbeInjectorworkaround it documented as temporary, and gains the three recurring-scope siblings (all/only-this/this-and-following), each asserting the untouched-field guarantee from [scheduler] Carry custom event data through the edit dialog submit #22874.SectionFieldset/SectionHeaderTitleinside a custom section,useEventDialogOccurrence(happy path + guard), and a pin that a value written in a conditionally unmounted section is still submitted.Docs
New "Event dialog" page under a Components section (mirroring the Data Grid toolbar page): anatomy, custom fields, validation, reorder/omit, required-resource semantics, typed slot props, and the pitfalls (return a fragment, module-scope slot component, draft state through the hook, read-only events). Cross-linked from the editing page and the accessibility page.
The moved section components are added to the API builder's skip list — they take zero props, so they are documented in the page's Anatomy section instead of empty API pages.