Skip to content

Improve portability of ToolpadApp#3126

Merged
Janpot merged 8 commits into
mui:masterfrom
Janpot:extract-next-stuff
Jan 25, 2024
Merged

Improve portability of ToolpadApp#3126
Janpot merged 8 commits into
mui:masterfrom
Janpot:extract-next-stuff

Conversation

@Janpot

@Janpot Janpot commented Jan 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Batch of changes extracted from #3125

  • Remove reliance on variables defined by the bundler. Use a context instead.
  • In binding engine, make sure there is always an iframe
  • Remove import.meta.url shims
  • Resolve platform incompatibilities with URL constructor in Next.js runtime
  • Remove outdated cjs exports

@Janpot Janpot added the internal Behind-the-scenes enhancement. Formerly called “core”. label Jan 25, 2024
@Janpot Janpot marked this pull request as ready for review January 25, 2024 11:05
@Janpot Janpot requested a review from a team January 25, 2024 11:05
@Janpot Janpot changed the title Improve portability of Toolpad app code Improve portability of ToolpadApp Jan 25, 2024
@Janpot Janpot merged commit 0831f50 into mui:master Jan 25, 2024
@Janpot Janpot deleted the extract-next-stuff branch January 25, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees

No one assigned

Labels

internal Behind-the-scenes enhancement. Formerly called “core”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Janpot @apedroferreira