fix: set UTF-8 input encoding for Windows stdin reading#50
Merged
Conversation
On Windows systems with a non-UTF-8 system codepage, [Console]::In.ReadToEnd() decodes UTF-8 stdin using the system codepage instead of UTF-8. This corrupts non-ASCII characters and breaks JSON parsing for hooks that receive non-ASCII data (e.g. PreToolUse with AskUserQuestion containing non-English text). Fix: set [Console]::InputEncoding to UTF-8 before reading stdin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows systems with a non-UTF-8 system codepage,
notify.ps1reads UTF-8 stdin from Claude Code hooks using[Console]::In.ReadToEnd(), which decodes bytes with the system codepage instead of UTF-8. This corrupts non-ASCII characters and breaks JSON parsing for any hook that receives non-ASCII data (e.g.PreToolUsewithAskUserQuestioncontaining non-English text).Fix
Add one line before reading stdin:
Testing
PreToolUsehooks with non-ASCII text in the JSON payload parse correctly after this fix