Skip to content

Re-enable NSKIP013 - #850

Merged
ppenna merged 1 commit into
nanvix/v3.12.3from
nskip/013
Aug 4, 2026
Merged

Re-enable NSKIP013#850
ppenna merged 1 commit into
nanvix/v3.12.3from
nskip/013

Conversation

@ada-x64

@ada-x64 ada-x64 commented Jul 31, 2026

Copy link
Copy Markdown

Closes #481

What

Remove NSKIP013 guard in test_exception_group.

Why

Argument position numbers render correctly now.
Verified the full lifecycle on Linux.

Copilot AI lite review requested due to automatic review settings July 31, 2026 22:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables a previously skipped ExceptionGroup constructor validation test on Nanvix by removing the NSKIP013 platform guard now that 32-bit argument position numbering in TypeError messages is reported to be fixed.

Changes:

  • Removed the @unittest.skipIf(support.is_nanvix, "NSKIP013: ...") decorator from test_bad_EG_construction__bad_message.
  • Removed the associated NSKIP013 tracking comment in the test file.
Suppressed comments (1)

Lib/test/test_exception_group.py:36

  • Removing the Nanvix skip means from test import support is now unused in this file (no remaining support. references). Unused imports are typically flagged by linters/formatting checks; please drop the import if it’s no longer needed.
    def test_bad_EG_construction__bad_message(self):
        MSG = 'argument 1 must be str, not '
        with self.assertRaisesRegex(TypeError, MSG):
            ExceptionGroup(ValueError(12), SyntaxError('bad syntax'))

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings August 3, 2026 14:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@ada-x64
ada-x64 marked this pull request as ready for review August 3, 2026 14:42
Argument position numbers render correctly now.
Copilot AI review requested due to automatic review settings August 4, 2026 21:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@ppenna
ppenna merged commit acc7a54 into nanvix/v3.12.3 Aug 4, 2026
13 checks passed
@ppenna
ppenna deleted the nskip/013 branch August 4, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NSKIP013] 32-bit arg numbering garbled

3 participants