Skip to content

Re-enable NSKIP028 #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ppenna merged 1 commit into from
Aug 4, 2026
Merged

Re-enable NSKIP028 #853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Lib/test/test_fileinput.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,9 +882,6 @@ def test_no_ext(self):
self.do_test_use_builtin_open_text("abcd", "r")

@unittest.skipUnless(gzip, "Requires gzip and zlib")
# NSKIP028 https://github.com/nanvix/cpython/issues/508
@unittest.skipIf(support.is_nanvix,
"NSKIP028: locale.getencoding() returns garbage on Nanvix standalone")
def test_gz_ext_fake(self):
original_open = gzip.open
gzip.open = self.fake_open
Expand All @@ -907,9 +904,6 @@ def test_gz_with_encoding_fake(self):
self.assertEqual(list(result), ['Ex-binary string'])

@unittest.skipUnless(bz2, "Requires bz2")
# NSKIP028 https://github.com/nanvix/cpython/issues/508
@unittest.skipIf(support.is_nanvix,
"NSKIP028: locale.getencoding() returns garbage on Nanvix standalone")
def test_bz2_ext_fake(self):
original_open = bz2.BZ2File
bz2.BZ2File = self.fake_open
Expand Down