Add an installer option to configure S3 object storage - #243
Merged
Conversation
The installer set up the catalog backends and access requests, but always wrote S3 as disabled with nothing to re-enable it, so object storage could only be added by hand-editing .env and starting the container manually. Offer S3 the same way as the other optional pieces — a --s3 flag and an interactive prompt — in two modes: install the bundled MinIO alongside the Endpoint (compose profile 's3'), or point at an S3-compatible service the operator already runs (including Amazon S3) via --s3-endpoint and its credentials. An install that does not ask for S3 renders exactly as before. Closes #242
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #242
Problem
The installer could set up the catalog backends (MongoDB, CKAN) and access requests, but it had no way to turn on S3 object storage. It always wrote S3 as disabled and nothing re-enabled it, so an Endpoint that should offer S3 bucket/object management could only get one by editing the
.envby hand and starting the container manually.What it does
Offers S3 the same way the other optional pieces are offered — an interactive prompt and a flag — in two modes, mirroring how MongoDB/CKAN do bundled-vs-existing:
--s3--s3-endpoint <host>(+--s3-access-key,--s3-secret-key,--s3-region,--s3-secure)s3(ndp-minio).envthe user providesminio:9000/minioadmin)When S3 is not chosen, nothing changes from before (
S3_ENABLED=False, no profile).Verified
--s3(bundled →S3_ENABLED=True,minio:9000, profiles3),--s3-endpoint …(existing → the given endpoint/creds, no profile), and no-S3 (unchangedS3_ENABLED=False).--s3-endpointwithout credentials fails cleanly.s3profile + points at MinIO, an existing S3 requires credentials, and MinIO is behind exactly thes3profile so the installer's profile starts it.install/tests/);black/flake8clean.install.shpassesbash -n.No backend or image code changes; the MinIO service already existed in
docker-compose.ymlbehind thes3profile.