Improve the service registration form: require-auth checkbox and success feedback - #249
Merged
Merged
Conversation
added 2 commits
August 17, 2026 07:31
A service can require its callers to be authenticated, stored as the extra requires_auth, but the only way to set it from the UI was to add an Additional metadata pair with that exact key — undiscoverable without knowing the internals. Add a labelled checkbox that sets extras.requires_auth = 'true' when ticked. The checkbox is authoritative for that extra; the free-form metadata section stays for everything else. Stored value is unchanged, so services protected by hand and through the checkbox are identical. Closes #248
The Register button sits at the bottom of a long form, and the success message rendered above it, off-screen, so a successful registration looked like nothing happened. On success, navigate to Search with a one-off success banner (handed over via router state and cleared from history), so the user gets clear feedback and lands where the new service is listed. Removes the now-unused inline success alert from the service form.
rbardaji
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #248
Two UI improvements to registering a service, found while testing it.
1. "Require authentication" checkbox
A service can require its callers to be authenticated (the Endpoint checks a
requires_authextra before forwarding through/services/redirect/...). The only way to set it from the UI was an Additional metadata pair with the exact keyrequires_auth— undiscoverable. The form now has a first-class Require authentication checkbox that setsextras.requires_auth = 'true'. The stored value is unchanged, so hand-protected and checkbox-protected services are identical.2. Registering confirms and returns to Search
The Register button is at the bottom of a long form, and the success message rendered above it (off-screen), so a successful registration read as "nothing happened". Registration now navigates to Search with a one-off success banner (passed via router state, cleared from history), where the new service is listed.
Verified
requires_authreturns 401 on/services/redirect/<name>without a token; an open service returns 200.react-scripts build,CI=true); both changes served in the bundle.