fix: do not create OAuth client when setting up with OIDC auth method

[saw-jan]

Description

Do not create OAuth client when setting up integration with oidc method.

Request:

POST /setup
{
...
}

1. for oauth method:

200 OK
{
  "status": true,
  "nextcloud_oauth_client_name": "...",
  "nextcloud_client_id": "...",
  "nextcloud_client_secret": "...",
  "openproject_redirect_uri": "..."
}

1. for oidc method:

200 OK
{
  "status": true
}

Related Issue or Workpackage

• Fixes https://community.openproject.org/wp/NEX-628

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Updated CHANGELOG.md file

[Copilot]

Pull request overview

This PR adjusts the /setup integration endpoint so that OAuth client creation only happens when the OAuth2 authorization method is used, and not when configuring the integration via OIDC (matching the API behavior described in NEX-628).

Changes:

• Update ConfigController::setUpIntegration() to only recreate/create a Nextcloud OAuth client when authorization_method is OAuth2, and always include a status field in responses.
• Add/adjust controller tests to cover successful setup responses for both OAuth2 and OIDC.
• Update static analysis config (Psalm) and document the fix in CHANGELOG.md.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
lib/Controller/ConfigController.php	Gate OAuth client recreation behind the OAuth2 auth method; include status in both success and error responses.
tests/lib/Controller/ConfigControllerTest.php	Add provider-driven tests to validate /setup responses for OAuth2 vs OIDC, plus minor test refactors.
psalm.xml	Ignore tests/stub during Psalm analysis.
CHANGELOG.md	Add an Unreleased “Fixed” entry for the OIDC setup behavior change.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

[github-actions]

JS Code Coverage

Coverage after merging fix/conditional-oauth-client into release/2.11 will be

91.03%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
adminSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2–9
bootstrap.js	0%	0%	0%	0%	1, 1, 10–12, 2–9
dashboard.js	0%	0%	0%	0%	1, 1, 10–19, 2–9
fileActions.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–23, 3–9
personalSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2–9
projectTab.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50, 6–9
reference.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–45, 5–9
utils.js	85.71%	62.50%	66.67%	87.41%	12–14, 142–143, 15–20, 23–32
src/api
endpoints.js	100%	100%	100%	100%
settings.js	64.71%	100%	0%	73.33%	10–11, 14–15
src/components
AdminSettings.vue	96.33%	96.03%	95.88%	96.41%	1005, 1008–1014, 1044–1045, 1049–1050, 1053–1054, 1058–1059, 1069–1074, 1146–1148, 1160–1163, 1176–1178, 1202–1205, 1239–1247, 1304–1306, 1341–1344, 1380–1382, 1402–1405, 724, 835–837, 992–994
ErrorLabel.vue	100%	100%	100%	100%
OAuthConnectButton.vue	91.85%	75%	100%	93.28%	64–69, 72–76
PersonalSettings.vue	92.02%	95.65%	90%	91.71%	133–134, 144–149, 152–161
src/components/admin
FieldValue.vue	100%	100%	100%	100%
FormAuthMethod.vue	98.12%	96.88%	100%	98.12%	222–224, 247–250
FormHeading.vue	100%	100%	100%	100%
FormOpenProjectHost.vue	98.90%	95%	100%	99.35%	175–177, 287
TermsOfServiceUnsigned.vue	100%	100%	100%	100%
TextInput.vue	100%	100%	100%	100%
src/components/icons
ClippyIcon.vue	100%	100%	100%	100%
OpenProjectIcon.vue	100%	100%	100%	100%
src/components/settings
CheckBox.vue	100%	100%	100%	100%
ErrorNote.vue	100%	100%	100%	100%
SettingsTitle.vue	96.91%	85.71%	100%	97.67%	51–53
src/components/tab
EmptyContent.vue	96.45%	80.95%	100%	98.24%	102–105, 107–108, 97
SearchInput.vue	95.31%	92.96%	94.74%	95.78%	138–139, 192, 203–208, 267–269, 285–287, 291–296
WorkPackage.vue	86.22%	72.50%	93.33%	87.62%	107–116, 129–131, 142–146, 156–158, 176–182, 220, 220–225, 225, 225–236, 81–82
src/constants
appID.js	100%	100%	100%	100%
links.js	100%	100%	100%	100%
messages.js	100%	100%	100%	100%
src/filesPlugin
filesPlugin.js	0%	0%	0%	0%	1, 1, 10, 100, 11–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
filesPluginLessThan28.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70, 8–9
src/utils
workpackageHelper.js	93.80%	93.10%	88.89%	94.24%	100–102, 23–27, 54, 54–56, 97–99
src/views
CreateWorkPackageModal.vue	94.18%	86.32%	90.48%	95.43%	367–372, 375, 391, 508–511, 516–521, 526–531, 537–540, 543, 559, 559, 600–604, 614–616, 639–640, 648–650, 679–681, 703–705, 714–718
Dashboard.vue	92.96%	92.86%	82.61%	93.77%	120–125, 134, 144, 147, 158–160, 214–217, 220–221, 228–232, 67
LinkMultipleFilesModal.vue	99.14%	97.56%	100%	99.32%	157–159
ProjectsTab.vue	94.06%	92.45%	93.33%	94.33%	100–101, 107–109, 129, 140–141, 175–185, 234–236, 98–99

[github-actions]

PHP Code Coverage

Coverage after merging fix/conditional-oauth-client into release/2.11 will be

67.36%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
integration_openproject/server/apps/integration_openproject/lib
Capabilities.php	0%	100%	0%	0%	24, 31–40
OIDCClientMapper.php	0%	100%	0%	0%	29, 40–49, 52
TokenEventFactory.php	100%	100%	100%	100%
integration_openproject/server/apps/integration_openproject/lib/AppInfo
Application.php	36.59%	100%	50%	35.53%	105–107, 110–114, 116–121, 123–124, 127, 132–133, 135–138, 140, 142, 144, 148–151, 153–164, 166, 169, 173, 177–179, 212
integration_openproject/server/apps/integration_openproject/lib/BackgroundJob
RemoveExpiredDirectUploadTokens.php	0%	100%	0%	0%	28, 30–32, 41–42
integration_openproject/server/apps/integration_openproject/lib/Controller
ConfigController.php	74.53%	100%	64.71%	74.94%	114, 151–152, 154, 156–158, 160–163, 166–167, 169, 194, 198–200, 442–444, 446–448, 497, 541–543, 577–581, 592, 606–609, 617, 621–624, 662, 668–687, 704–709, 711–712, 714–716, 719, 721–737, 751–754, 756–760
DirectDownloadController.php	0%	100%	0%	0%	33–35, 50–52, 54–61
DirectUploadController.php	71.03%	100%	100%	70.21%	117–119, 162–164, 175, 179–182, 184, 194, 201, 217–219, 221–222, 225–230, 233, 235, 245–247, 253–255, 263–265, 280–282, 301, 306, 312
FilesController.php	86.99%	100%	83.33%	87.18%	178–179, 241, 250, 267–270, 275–277, 282–284, 293
OpenProjectAPIController.php	80.51%	100%	82.35%	80.34%	107, 146, 193–195, 198–205, 207–211, 213, 232, 257, 322, 372, 392, 439, 464–466, 469–473, 475, 66
OpenProjectController.php	96.45%	100%	80%	96.95%	241–245
integration_openproject/server/apps/integration_openproject/lib/Dashboard
OpenProjectWidget.php	0%	100%	0%	0%	101, 108–109, 111–116, 118–122, 124–126, 129–140, 61–66, 73, 80, 87, 94
integration_openproject/server/apps/integration_openproject/lib/Exception
OpenprojectAvatarErrorException.php	100%	100%	100%	100%
OpenprojectErrorException.php	100%	100%	100%	100%
OpenprojectFileNotUploadedException.php	100%	100%	100%	100%
OpenprojectGroupfolderSetupConflictException.php	100%	100%	100%	100%
OpenprojectResponseException.php	100%	100%	100%	100%
OpenprojectUnauthorizedUserException.php	0%	100%	0%	0%	21
integration_openproject/server/apps/integration_openproject/lib/Listener
BeforeGroupDeletedListener.php	100%	100%	100%	100%
BeforeNodeInsideOpenProjectGroupfilderChangedListener.php	0%	100%	0%	0%	46–48, 52–55, 57, 59, 62–63, 65, 67–70, 72–75, 77–79
BeforeUserDeletedListener.php	0%	100%	0%	0%	30, 37–38, 40–43, 45
LoadAdditionalScriptsListener.php	0%	100%	0%	0%	37–38, 46–47, 49, 51–52, 54
LoadSidebarScript.php	65.91%	100%	100%	64.29%	105, 77–88, 95, 98
OpenProjectReferenceListener.php	0%	100%	0%	0%	45–47, 54–55, 57, 59–60, 62–74
TermsOfServiceEventListener.php	0%	100%	0%	0%	41–42, 47–48, 50–51, 53–55, 58–62
UserChangedListener.php	0%	100%	0%	0%	34, 41–42, 45–50, 53
integration_openproject/server/apps/integration_openproject/lib/Migration
Version2001Date20221213083550.php	0%	100%	0%	0%	30, 40–48, 50–58, 60–62, 64
Version20100Date20250820101358.php	0%	100%	0%	0%	38, 47–53, 56
Version2310Date20230116153411.php	0%	100%	0%	0%	29, 32–35, 37–62, 64–65, 67
Version2400Date20230504144300.php	0%	100%	0%	0%	30, 40–43
Version2640Date20240628114301.php	0%	100%	0%	0%	35, 47–49, 52–53, 56
Version2900Date20250718065820.php	0%	100%	0%	0%	22, 33–36, 38–39, 41–42, 45
integration_openproject/server/apps/integration_openproject/lib/Reference
WorkPackageReferenceProvider.php	51.67%	100%	25%	58.33%	100–101, 104, 108, 142, 150–151, 159, 37, 44, 51, 58–60, 87, 93–96, 99
integration_openproject/server/apps/integration_openproject/lib/Search
OpenProjectSearchProvider.php	0%	100%	0%	0%	100–102, 104–106, 109–110, 112–113, 116–125, 127–131, 52–55, 62, 69, 77, 79, 82, 89–90, 93–97, 99
OpenProjectSearchResultEntry.php	100%	100%	100%	100%
integration_openproject/server/apps/integration_openproject/lib/Service
DatabaseService.php	42.31%	100%	60%	40.43%	108–112, 114, 63–76, 78–85
DirectDownloadService.php	88.46%	100%	100%	87.50%	62–63, 65
DirectUploadService.php	42.86%	100%	66.67%	40%	101, 62–65, 67–75, 95
OauthService.php	0%	100%	0%	0%	100–101, 40–42, 51–58, 60–66, 75–83, 94–99
OpenProjectAPIService.php	76.48%	100%	78.87%	76.29%	1006–1007, 1009,

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.