fix: introduce UI toggle to allow/disallow updating

[Antreesy]

☑️ Resolves

• Frontend on top of fix(sharing): Allow sharing with read-write again #18485

AI (if applicable)

• The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before	🏡 After
Screenshot before

🚧 Tasks

• Default is 'off'?

🏁 Checklist

• 🌏 Tested with different browsers / clients:
  • Chromium (Chrome / Edge / Opera / Brave)
  • Firefox
  • Safari
  • Talk Desktop
  • Integrations with Files sidebar and other apps
  • Not risky to browser differences / client
• 🖌️ Design was reviewed, approved or inspired by the design team
• ⛑️ Tests are included or not possible
• 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required[skip ci]

Signed-off-by: Maksim Sukharev antreesy.web@gmail.com

[nimishavijay]

Why are we not always allowing editing? 🤔 There is no switch to allow editing for text, so this extra switch feels a bit disruptive. We should indicate that a file has been edited always in the message, though. If we do want a switch I would suggest we keep it enabled by default and a bit more hidden, what do you think?

[nickvergessen]

Why are we not always allowing editing?

We had reports before, especially when sharing screenshots and images it's totally unexpected that others can replace/edit them.
And also in no other messenger is the default "everyone in this room can modify my shared content"

We should indicate that a file has been edited always in the message, though.

Not technically possible

If we do want a switch I would suggest we keep it enabled by default and a bit more hidden, what do you think?

As per team week discussion we are most likely going to add a compression toggle anyway, so it would just be 2 for now.

[nimishavijay]

We had reports before, especially when sharing screenshots and images it's totally unexpected that others can replace/edit them. And also in no other messenger is the default "everyone in this room can modify my shared content"

Is it "everyone in the room" or just moderators? What would be the use case for others being able to edit the image? If it is technically not possible then maybe we just don't allow editing for images for the sake of transparency?

Taking a quick look at Teams, Slack, Google Workspace Chat and Discord don't allow others to edit even text messages in the first place. This switch being so present is asking the user to make another decision before the simple and very commonly used action of sending an image.

[Antreesy]

Is it "everyone in the room" or just moderators?

Everyone got write permissions before, if file uploaded directly to Talk

What would be the use case for others being able to edit the image?

Organisations working with visual materials / marketing maybe?

Maybe we just don't allow editing for images for the sake of transparency?

That sounds like another way of working around current behaviour (everything is read-only, if you need editing - share from Files app). Also video/audio could fall into that category. Or the other way around, somehow receive list of office-provided filetype (+ .txt .md files), and allow edit them by default - but I agree now that is also subtle and non-obvoius behaviour

This switch being so present

We can default back to legacy switches (toggle on the left side, smaller) or checkboxes

[ShGKme]

All good code-wise

[DorraJaouad]

Tested, yet I am not sure if showing this toggle for images /videos only shares is good

[Antreesy]

/backport to stable34