Skip to content

fix: Use system actor for SAML provisioned users added to existing groups#18515

Merged
SystemKeeper merged 1 commit into
mainfrom
fix/noid/use-system-for-saml-group-provision
Jul 2, 2026
Merged

fix: Use system actor for SAML provisioned users added to existing groups#18515
SystemKeeper merged 1 commit into
mainfrom
fix/noid/use-system-for-saml-group-provision

Conversation

@SystemKeeper

Copy link
Copy Markdown
Contributor

πŸ› οΈ API Checklist

  • Have SAML configured that also maps groups
  • Add a SAML group to a talk conversation
  • Login through SAML with a new user that is part of the SAML group before

Before
SCR-20260701-qobl

After this PR
SCR-20260701-qnvn

After this PR combined with #18512
SCR-20260701-qowz

Ref of the attribute: https://github.com/nextcloud/user_saml/blob/54436b20d0e4bc916f242ecdbe988a9a3404f626/lib/Model/SessionData.php#L14

Ref stacktrace:
SCR-20260527-sqes

I did not find any existing tests around the session handling with talk-overwrite-actor-id for example, so not fully sure if we should add one here.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • πŸ“˜ API documentation in docs/ has been updated or is not required
  • πŸ”– Capability is added or not needed

…oups

Signed-off-by: Marcel MΓΌller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper added this to the β›… Next Major (35) milestone Jul 1, 2026
@SystemKeeper SystemKeeper self-assigned this Jul 1, 2026
@SystemKeeper SystemKeeper added enhancement feature: chat πŸ’¬ Chat and system messages feature: api πŸ› οΈ OCS API for conversations, chats and participants labels Jul 1, 2026
@SystemKeeper

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@SystemKeeper

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@SystemKeeper SystemKeeper changed the title fix: Use system actor for SAML provisioned users added to existing gr… fix: Use system actor for SAML provisioned users added to existing groups Jul 1, 2026
@SystemKeeper SystemKeeper merged commit ca475a8 into main Jul 2, 2026
79 checks passed
@SystemKeeper SystemKeeper deleted the fix/noid/use-system-for-saml-group-provision branch July 2, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement feature: api πŸ› οΈ OCS API for conversations, chats and participants feature: chat πŸ’¬ Chat and system messages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants