feat: nginx loadbalancing validation - #778
Draft
buchdag wants to merge 4 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds validation and normalization for NGINX load-balancing directives.
Changes:
- Implements parsers for supported load-balancing methods.
- Adds table-driven parser tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
internal/template/nginx_validation.go |
Adds load-balancing validation logic. |
internal/template/nginx_validation_test.go |
Tests accepted and rejected directives. |
Suppressed comments (1)
internal/template/nginx_validation.go:112
- The NGINX
hashdirective requires a key (hash key [consistent]), so accepting the one-element case returns a barehashdirective that NGINX will reject when validating the generated configuration. Return an error when the key is missing and update the test that currently accepts this input.
case 1:
// no parameters
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.