DO NOT MERGE: CI check against ngrok-rust PR #203 (Rust 2024 + dep bumps)#163
Draft
bmpngrok wants to merge 1 commit into
Draft
DO NOT MERGE: CI check against ngrok-rust PR #203 (Rust 2024 + dep bumps)#163bmpngrok wants to merge 1 commit into
bmpngrok wants to merge 1 commit into
Conversation
…mps) Verifies ngrok-python builds/lints clean against the not-yet-merged ngrok-rust PR #203 (ngrok/ngrok-rust#203), which moves the SDK to Rust 2024 edition and bumps security deps. No glue-code changes were required; ngrok-python itself stays on edition 2021. This PR exists only to exercise the CI suite against PR #203. It MUST NOT be merged: it depends on an unmerged branch via a [patch.crates-io] git ref. When PR #203 merges and a new ngrok release ships, drop the [patch] section and bump the `ngrok` version dependency instead. Changes: - Cargo.toml: TEMPORARY [patch.crates-io] ngrok -> git branch bmps/bump-the-security-deps (lock pins the exact rev). - Cargo.toml: bump aws-lc-sys =0.41.0 / aws-lc-rs =1.17.0 to match PR #203 (aws-lc-sys is a `links` crate, so versions must unify). - flake.lock: bump fenix -> 1.98-nightly. The SDK's edition 2024 + let-chains need rustc >= 1.88; the old pinned 1.82 nightly can't build it. - flake.lock: bump nixpkgs -> 2026-06-29. The old cargo-udeps (Cargo 1.79) cannot parse edition-2024 manifests and fails the Udeps job; this applies once the SDK is published too, not just under the patch. - flake.nix: flatten devShell buildInputs (nested lists deprecated in nixpkgs 26.05, surfaced by the bump). Verified locally: cargo check, clippy, rustfmt, udeps pass; maturin develop links + `import ngrok` works. Live integration tests need an authtoken -> validated by CI here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifies ngrok-python builds and passes CI against the not-yet-merged ngrok-rust PR #203 (Rust 2024 edition + security dep bumps).
Ref AGENT-626
This depends on an unmerged branch via a
[patch.crates-io]git ref (ngrok-rust@bmps/bump-the-security-deps). It exists solely to exercise the CI suite. When PR #203 merges and a newngrokrelease ships, the real change is: drop the[patch]section and bump thengrokversion — keeping the flake + aws-lc changes.What changed
Cargo.toml: temporary[patch.crates-io] ngrok→ git branch (lock pins the exact revc1e4354); bumpaws-lc-sys =0.41.0/aws-lc-rs =1.17.0to match PR #203 (it is alinkscrate, so versions must unify).flake.lock: bumpfenix→ 1.98-nightly (edition 2024 + let-chains need rustc ≥ 1.88; the old pinned 1.82 could not build it) andnixpkgs→ 2026-06-29 (the oldcargo-udeps, built against Cargo 1.79, cannot parse edition-2024 manifests and fails the Udeps job — true even once the SDK is published).flake.nix: flattendevShell.buildInputs(nested lists deprecated in nixpkgs 26.05, surfaced by the bump).Local verification
cargo check,clippy,rustfmt,udepsall pass;maturin developlinks andimport ngrokworks. No ngrok-python glue-code changes were needed. Live integration tests need an authtoken → thats what CI here validates.