Skip to content

Title bar#2084

Merged
nukeop merged 7 commits into
masterfrom
feat/title-bar
Jun 21, 2026
Merged

Title bar#2084
nukeop merged 7 commits into
masterfrom
feat/title-bar

Conversation

@nukeop

@nukeop nukeop commented Jun 21, 2026

Copy link
Copy Markdown
Owner

No description provided.

@codecov

codecov Bot commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.84848% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.19%. Comparing base (0777b07) to head (30f6691).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ckages/player/src/components/ConnectedTitleBar.tsx 83.33% 2 Missing ⚠️
packages/ui/src/components/KeyCombo/KeyCombo.tsx 80.00% 0 Missing and 2 partials ⚠️
...ages/ui/src/components/TitleBar/useTitleBarDrag.ts 75.00% 1 Missing and 1 partial ⚠️
packages/ui/src/providers/PlatformProvider.tsx 60.00% 2 Missing ⚠️
...src/views/KeyboardShortcuts/useShortcutRecorder.ts 75.00% 0 Missing and 1 partial ⚠️
packages/ui/src/components/TitleBar/TitleBar.tsx 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2084      +/-   ##
==========================================
+ Coverage   82.00%   82.19%   +0.19%     
==========================================
  Files         412      418       +6     
  Lines        5924     5966      +42     
  Branches     1187     1192       +5     
==========================================
+ Hits         4858     4904      +46     
- Misses        717      718       +1     
+ Partials      349      344       -5     
Flag Coverage Δ
unittests 82.19% <84.84%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Player (App) 85.80% <89.28%> (+0.08%) ⬆️
UI Library 76.87% <81.57%> (+0.61%) ⬆️
Hifi 75.42% <ø> (ø)
Data Model 70.49% <ø> (ø)
Plugin SDK ∅ <ø> (∅)
Themes 83.33% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nukeop nukeop merged commit 4bc4f35 into master Jun 21, 2026
20 checks passed
@nukeop nukeop deleted the feat/title-bar branch June 21, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant