feat: migrate to quick-crypto - #112
Closed
dougg0k wants to merge 3 commits into
Closed
Conversation
Collaborator
|
@dougg0k I don't think this PR is necessary, the encryption constructors only run once when building the application, there is no need to add a native library |
Contributor
Author
|
And this was closed, why? @ngocle2497 |
Collaborator
|
This PR adds 2 native libraries, currently nitro module requires new arch and this library supports both. Furthermore, is it worth adding 2 native libraries to solve the problem of generating randombytes in prebuild(not runtime)? |
Collaborator
|
and is it possible to call a function of a native library when there is no runtime? the flow of this library is as follows: start build -> create files -> build success -> app run(runtime available) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit:
CI might need to be re-run after this PR is merged. #113
This is the changes requested in #89
https://github.com/margelo/react-native-quick-crypto
I didnt actually test anything because the setup of this project does not have a setup to easily do so. I suppose the CI can somewhat do so.
Feel free to test this PR first, before merge though.