Skip to content

Removed problematic system-* icons#4585

Open
Foggalong wants to merge 7 commits into
masterfrom
system-icons
Open

Removed problematic system-* icons#4585
Foggalong wants to merge 7 commits into
masterfrom
system-icons

Conversation

@Foggalong

Copy link
Copy Markdown
Contributor

Fixes #3681

@Foggalong Foggalong added this to the 18.09.19 milestone Sep 19, 2018
@Foggalong Foggalong requested a review from palob as a code owner September 19, 2018 17:23
@palob

palob commented Sep 19, 2018

Copy link
Copy Markdown
Member

Will have a look in 2 hours or so.

@Foggalong

Copy link
Copy Markdown
Contributor Author

I wasn't so sure on gnome-session-hibernate and gnome-session-suspend. Does anyone who uses GNOME know if those are used exclusively in launchers or are they action icons also?

@palob

palob commented Sep 19, 2018

Copy link
Copy Markdown
Member

AFAIK Ubuntu uses/used such launchers but I think the icons are named differently. I can't see them pop up in my GNOME. Since GNOME switched pretty much everything except for app icons to symbolic I can't think of a place where they would.
Even Adwaita doesn't contain any session-*.

Given that we've got mate-session-* icons in our theme maybe MATE, Xfce or Cinnamon do use this type of icons

@palob

palob commented Sep 19, 2018

Copy link
Copy Markdown
Member

Found the icons in the app directory of the Linux mint theme

Same for elementary-xfce.

@palob

palob commented Sep 19, 2018

Copy link
Copy Markdown
Member

No such app icons in the MATE theme https://github.com/mate-desktop/mate-icon-theme.

@palob

palob commented Sep 19, 2018

Copy link
Copy Markdown
Member

Xfce even got the removed ones :-( so we'll probably have to check some distros in real life.

@Foggalong

Copy link
Copy Markdown
Contributor Author

Damn, will asign this to next release so we can do some proper testing.

@Foggalong Foggalong modified the milestones: 18.09.19, 18.10.03 Sep 19, 2018
@Foggalong Foggalong modified the milestones: 18.10.03, 18.10.17 Oct 4, 2018
@bilelmoussaoui

Copy link
Copy Markdown
Contributor

Those icons should be removed and moved to Numix base theme as they are actions and not apps. That's where they are installed on the elementary theme (they follow the standards more than XFCE/Mate guys.)
Those GNOME icons are from GNOME2. They are not found here on my system (Fedora Rawhide with GNOME)

@Foggalong

Copy link
Copy Markdown
Contributor Author

@bilelmoussaoui It might be the case, but we do need to make sure removing them outright won't break things

@palob

palob commented Oct 28, 2024

Copy link
Copy Markdown
Member

Found the icons in the app directory of the Linux mint theme

Same for elementary-xfce.

Looks like this isn't the case anymore.

@palob

palob commented Feb 21, 2026

Copy link
Copy Markdown
Member

I'm very aware of that. Who did let loose that bot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

Are system-suspend-(hibernate) supposed to be app icons?

3 participants