fix: re-use prompt rows after a quiet buffer editor#1107
Open
reubeno wants to merge 1 commit into
Open
Conversation
The buffer-editor success path re-initialized the prompt position from scratch; with the cursor still sitting after the old buffer text (column > 0), select_prompt_row would start a new prompt one row down, leaving a stale duplicate prompt row above. Capture the painter's suspended state before spawning the editor and re-initialize with it: an editor that wrote nothing to the tty leaves the cursor inside the previous prompt rows and re-uses them (in-place repaint, as before this branch); an editor that printed output moves the cursor out of range and gets a fresh prompt below that output. Found by the PTY e2e suite: editor_replaces_buffer regressed on this branch while editor_that_prints_to_tty_does_not_corrupt_repaint regressed on main. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buffer-editor success path re-initialized the prompt position from scratch; with the cursor still sitting after the old buffer text,
select_prompt_rowwould start a new prompt one row down, leaving the original input line above.This change captures the painter's state before spawning the editor and restore with it; if the editor wrote nothing to the tty (or did so on the alternate screen only) this allows reusing the original prompt row. An editor that printed output should get a fresh row.
Closes #1106