Add support for Google Calendar color_id field on Events#314
Open
burtonrhodes wants to merge 5 commits intonylas:mainfrom
Open
Add support for Google Calendar color_id field on Events#314burtonrhodes wants to merge 5 commits intonylas:mainfrom
burtonrhodes wants to merge 5 commits intonylas:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
=========================================
Coverage 82.47% 82.47%
Complexity 357 357
=========================================
Files 37 37
Lines 1027 1027
Branches 95 95
=========================================
Hits 847 847
Misses 121 121
Partials 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as low quality.
This comment was marked as low quality.
googsvg
approved these changes
Apr 30, 2026
Contributor
|
@burtonrhodes thank you so much for your contribution ❤️ we appreciate community suggestions and updates, so this is more than welcome PR :) it will be released with next SDK deployment, soon :) |
Contributor
Author
|
@googsvg Of course! Will be glad to use in the next release. My users have been wanting this for a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
colorIdfield toEvent,CreateEventRequest, andUpdateEventRequestmodels, mapped to thecolor_idJSON propertycolorId(String)builder methods on the create/update request buildersTest plan
EventsTeststo assertcolor_idis deserialized on event fetchcolorId./gradlew testpasses locallyLicense
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
The license confirmation line is required per Contributing.md and pull_request_template.md since this is a contribution from outside Nylas.
Note
Low Risk
Additive, optional model field and builder setters with test coverage; minimal behavioral change aside from extra JSON property when provided.
Overview
Adds first-class support for Google Calendar event colors by introducing an optional
colorIdfield onEvent,CreateEventRequest, andUpdateEventRequest, mapped to thecolor_idJSON property.Extends the create/update request builders to set
colorId, updates the changelog, and expandsEventsTeststo covercolor_idserialization/deserialization and omission when unset (including clearing vianullon the update builder).Reviewed by Cursor Bugbot for commit c267395. Bugbot is set up for automated code reviews on this repo. Configure here.