docs(ui-accuracy): remove non-existent Build Service overflow-menu step#1281
Conversation
Signed-off-by: ekline[bot] <202747777+ekline[bot]@users.noreply.github.com>
ekline
Bot
requested review from
codyjlandstrom,
ifbyol,
pchico83 and
rlamana
as code owners
✅ Deploy Preview for okteto-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![ekline[bot]](https://avatars.githubusercontent.com/in/1173463?s=60&v=4){kind=small}
|
|
||
| Within the newly created Workload Identity Pool, register your Kubernetes cluster as an OIDC Identity Provider in GCP. | ||
| To do this, Okteto provides the OIDC endpoint of your cluster, which can be found under the Integrations -> Cloud Credentials section of your Okteto Admin Dashboard. | ||
| To do this, you can find the OIDC endpoint of your cluster under the Integrations -> General section of your Okteto Admin Dashboard. |
There was a problem hiding this comment.
UI accuracy (High): the doc previously sent readers to Integrations → Cloud Credentials for the OIDC endpoint. The OIDC issuer and subject are actually rendered on the General Integrations page — OidcIntegration is mounted inside AdminIntegrations (admin integrations route), confirmed in app/frontend/src/features/AdminIntegrations/AdminIntegrations.tsx:63 and OidcIntegration.tsx. The Cloud Credentials page has no OIDC display. Path corrected to Integrations → General. The sibling amazon-ecr.mdx already describes it this way.
There was a problem hiding this comment.
Reverted — this UI-accuracy edit was determined to be inaccurate and the file has been restored to its original content. Disregard this suggestion.
| - **Role ARN**: The Role ARN `ROLE_ARN` you created in Step 2. | ||
| - **Region**: The AWS Region for the AWS STS Regional Endpoint. You can find more information about regional endpoints [here](https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_temp_enable-regions.html) and [here](https://docs.aws.amazon.com/sdkref/latest/guide/feature-sts-regionalized-endpoints.html) | ||
| - **Audience**: The Audience `AUDIENCE` that we defined in Step 1. | ||
| - **Audience JWT Claim**: The Audience `AUDIENCE` that we defined in Step 1. |
There was a problem hiding this comment.
UI accuracy (Medium): the AWS IAM Role form field is labeled Audience JWT Claim, not Audience. Confirmed in app/frontend/src/features/CloudCredentialsAdmin/ChangeModal/AwsForm.tsx:44 (required('Audience JWT Claim')) and :116 (FormField.Label text "Audience JWT Claim"). The label now matches the form, and is consistent with the sibling gcp.mdx which already uses "Audience JWT Claim".
There was a problem hiding this comment.
Reverted — this UI-accuracy edit was determined to be inaccurate and the file has been restored to its original content. Disregard this suggestion.
|
|
||
| 1. Locate the pod you want to restart in the Build Service dashboard | ||
| 2. Click the **Restart** button (or the overflow menu → **Restart**) | ||
| 2. Click the **Restart** button |
There was a problem hiding this comment.
UI accuracy (Medium): removed the (or the overflow menu → Restart) alternative — no overflow/more menu exists in the Build Service pod table. The table renders only a direct Restart button, confirmed in app/frontend/src/features/BuildService/Admin/BuildServiceTable.tsx:164-165; a grep for overflow/more-menu components in that file returns nothing. The following step's Delete and recreate confirm label is also accurate (BuildServiceTable.tsx:219).
Signed-off-by: ekline[bot] <202747777+ekline[bot]@users.noreply.github.com>
ekline
Bot
changed the title
1 participant
Context
This PR fixes a factual mismatch between documentation and the Okteto frontend UI, verified against the current component code under
app/frontend/src. Cosmetic and stylistic changes are intentionally out of scope.Fix
admin/build-service.mdxBuildServiceTable.tsxrenders only a direct Restart button; no overflow/more menu existsHow to verify
app/frontend/src/features/BuildService/Admin/BuildServiceTable.tsx:164-165; the following step's Delete and recreate confirm label is accurate (BuildServiceTable.tsx:219).Reverted from this PR
Two earlier UI-accuracy edits were reverted after review — they were determined to be inaccurate:
admin/cloud-credentials/gcp.mdx— proposed OIDC endpoint path change (reverted to original).admin/cloud-credentials/aws.mdx— proposed "Audience JWT Claim" label change (reverted to original).📝 Created with EkLine · View session