chore(sbom): Align supported accesses/types with odg-core - #474
Conversation
For reference, see open-component-model/odg-core#906 Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
📝 WalkthroughWalkthroughThe SBOM download popover now validates access types and artefact types independently. It adds ChangesSBOM resource support validation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/util/sbomDownloadPopover.js`:
- Around line 56-57: Update the unsupported-resource alert near the validation
using SUPPORTED_ACCESS_TYPES and SUPPORTED_ARTEFACT_TYPES so its message
mentions both unsupported access types and artefact types, rather than only
artefact access types.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 05114b02-c473-4e7c-854c-6359e93fe6c2
📒 Files selected for processing (1)
src/util/sbomDownloadPopover.js
What this PR does / why we need it:
For reference, see open-component-model/odg-core#906
Which issue(s) this PR fixes:
Fixes open-component-model/open-delivery-gear#205
Special notes for your reviewer:
Release note: