Skip to content

chore(sbom): Align supported accesses/types with odg-core - #474

Merged
8R0WNI3 merged 1 commit into
open-component-model:masterfrom
8R0WNI3:master
Aug 12, 2026
Merged

chore(sbom): Align supported accesses/types with odg-core#474
8R0WNI3 merged 1 commit into
open-component-model:masterfrom
8R0WNI3:master

Conversation

@8R0WNI3

@8R0WNI3 8R0WNI3 commented Aug 10, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:
For reference, see open-component-model/odg-core#906

Which issue(s) this PR fixes:
Fixes open-component-model/open-delivery-gear#205

Special notes for your reviewer:

Release note:


For reference, see open-component-model/odg-core#906

Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
@8R0WNI3 8R0WNI3 self-assigned this Aug 10, 2026
@8R0WNI3
8R0WNI3 requested a review from a team as a code owner August 10, 2026 07:54
@8R0WNI3 8R0WNI3 added kind/feature new feature, enhancement, improvement, extension area/ipcei Important Project of Common European Interest labels Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The SBOM download popover now validates access types and artefact types independently. It adds ociBlob/v1 access support and recognises additional artefact types, including ociArtifact/v1.

Changes

SBOM resource support validation

Layer / File(s) Summary
Independent resource allowlists
src/util/sbomDownloadPopover.js
Replaces access-type-specific compatibility mapping with separate allowlists. Supports ociBlob/v1, ociArtifact/v1, and the listed artefact types.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: zkdev

Poem

A rabbit checks the types in line,
OCI treasures now align.
Blobs and artefacts pass the gate,
Tar and trees no longer wait.
Independent lists now hop,
SBOM downloads reach the top.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The change adds OCI-related types, but it does not demonstrate support for local index manifests, nested OCI artifacts, or general OCM v2 behavior required by [#205]. Add or document code changes that cover local untagged OCI artifacts, index-manifest references, nested OCI artifacts, and general OCM v2 handling.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: aligning supported SBOM accesses and types with odg-core.
Description check ✅ Passed The description includes the change rationale, linked issue, reviewer notes section, and a valid release note classification.
Out of Scope Changes check ✅ Passed The allowlist changes are directly related to aligning SBOM resource support with the linked OCM v2 objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/util/sbomDownloadPopover.js`:
- Around line 56-57: Update the unsupported-resource alert near the validation
using SUPPORTED_ACCESS_TYPES and SUPPORTED_ARTEFACT_TYPES so its message
mentions both unsupported access types and artefact types, rather than only
artefact access types.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 05114b02-c473-4e7c-854c-6359e93fe6c2

📥 Commits

Reviewing files that changed from the base of the PR and between 02584c2 and c417476.

📒 Files selected for processing (1)
  • src/util/sbomDownloadPopover.js

Comment thread src/util/sbomDownloadPopover.js
Comment thread src/util/sbomDownloadPopover.js
@8R0WNI3
8R0WNI3 requested a review from zkdev August 10, 2026 08:18

@zkdev zkdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@8R0WNI3
8R0WNI3 merged commit d832ae6 into open-component-model:master Aug 12, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ipcei Important Project of Common European Interest kind/feature new feature, enhancement, improvement, extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Full support of OCM v2

2 participants