Open
Conversation
Added clarifying text and improved examples for MultiPolygon domain
improved punctuation
awarde96
reviewed
Apr 22, 2026
awarde96
left a comment
There was a problem hiding this comment.
I think this looks good and clarifies the multiPolygon, maybe to be more explicit we could add the range for the Polygon example with holes that there is only a single value in the range? Not fully needed but maybe helps people understand it is a single polygon.
{
"type" : "Coverage",
"domain" : {
"type": "Domain",
"domainType": "Polygon",
"axes": {
"composite": {
"dataType": "polygon",
"coordinates": ["x","y"],
"values": [
[ [ [100.0, 0.0], [101.0, 0.0], [101.0, 1.0], [100.0, 1.0], [100.0, 0.0] ]
[ [100.3, 0.2], [100.3, 0.4], [100.5, 0.4], [100.5, 0.2], [100.3, 0.2] ]
[ [100.7, 0.6], [100.8, 0.8], [100.9, 0.6], [100.7, 0.6] ] ]
]
},
"z": { "values": [2] },
"t": { "values": ["2008-01-01T04:00:00Z"] }
},
"referencing": [...]
},
"parameters" : {
"temperature": {...}
},
"ranges" : {
"temperature" : {
"type" : "NdArray",
"dataType": "float",
"values" : [273.15]
}
}
}
I would also add an explicit example of MultiPolygon where one of the Polygons has a hole.
{
"type": "Coverage",
"domain": {
"type": "Domain",
"domainType": "MultiPolygon",
"axes": {
"composite": {
"dataType": "polygon",
"coordinates": ["x", "y"],
"values": [
[
[
[40, 40],
[20, 45],
[45, 30],
[40, 40]
]
],
[
[
[20, 35],
[10, 30],
[10, 10],
[30, 5],
[45, 20],
[20, 35]
],
[
[30, 20],
[20, 15],
[20, 25],
[30, 20]
]
]
]
},
"z": {
"values": [2]
},
"t": {
"values": ["2008-01-01T04:00:00Z"]
}
},
"referencing": [...]
},
"parameters": {
},
"ranges": {
"temperature": {
"type": "NdArray",
"dataType": "float",
"axisNames": ["composite"],
"shape": [2],
"values": [23.1, 24.7]
}
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added example of a polygon with holes
Added text clarifying use of MultiPolygon and improved examples
Minor text edits