Skip to content

NO-ISSUE: OWNERS: Pratik is no longer at Red Hat :( - #271

Open
wking wants to merge 1 commit into
openshift:masterfrom
wking:emeritus-pratik
Open

NO-ISSUE: OWNERS: Pratik is no longer at Red Hat :(#271
wking wants to merge 1 commit into
openshift:masterfrom
wking:emeritus-pratik

Conversation

@wking

@wking wking commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated repository approval assignments to reflect a change in approver status.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@wking: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5afd7bc0-d43c-4a31-aced-ed633c508c1e

📥 Commits

Reviewing files that changed from the base of the PR and between 0c73b3c and bd47825.

📒 Files selected for processing (1)
  • OWNERS

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The OWNERS file removes PratikMahajan from approvers and adds the name to emeritus_approvers.

Changes

OWNERS status update

Layer / File(s) Summary
Update approver status
OWNERS
The file moves PratikMahajan from approvers to emeritus_approvers.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bd478

This localized ownership update introduces no actionable merge-blocking risk and is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the ownership update for PratikMahajan, which matches the main change in OWNERS.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only OWNERS membership; it introduces no Ginkgo test titles or dynamic test-name values.
Test Structure And Quality ✅ Passed The pull request changes only OWNERS metadata; it adds no Ginkgo test code or cluster operations, so this test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed The pull request changes only OWNERS; it adds no Ginkgo tests or test behavior that could use unavailable MicroShift APIs or features.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only OWNERS metadata; it adds no Ginkgo e2e tests or multi-node behavior, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The patch changes only OWNERS membership, moving PratikMahajan from approvers to emeritus_approvers; it adds no manifests, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The pull request changes only OWNERS metadata; it adds no process-level code or stdout writes in main, init, or suite setup.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request changes only OWNERS metadata (+1/-1); it adds no Ginkgo tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto ✅ Passed The parent-to-HEAD diff changes only OWNERS, moving PratikMahajan between approver lists; it introduces no crypto, comparison, or token-handling code.
Container-Privileges ✅ Passed The commit changes only OWNERS, moving PratikMahajan between owner lists; it introduces no container or Kubernetes manifest privilege settings.
No-Sensitive-Data-In-Logs ✅ Passed The patch only moves PratikMahajan in OWNERS; it adds no logging and exposes no passwords, tokens, keys, PII, hostnames, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Aug 21, 2026
@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

The OWNERS file contains untrusted users, which makes it INVALID. The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing /verify-owners in a comment.

  • PratikMahajan
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Comment thread OWNERS
- DavidHurta
- hongkailiu
reviewers:
- PratikMahajan

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that we can remove Pratik from reviewers as well.

Suggested change

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have to #271 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants