Skip to content

DNM: dry run ci for upstream e2e test changes#465

Draft
mfbonfigli wants to merge 3 commits into
openshift:mainfrom
mfbonfigli:dnm-test-branch
Draft

DNM: dry run ci for upstream e2e test changes#465
mfbonfigli wants to merge 3 commits into
openshift:mainfrom
mfbonfigli:dnm-test-branch

Conversation

@mfbonfigli
Copy link
Copy Markdown
Contributor

@mfbonfigli mfbonfigli commented May 21, 2026

Do Not Merge / wip

Testing CI execution in downstream following up on planned upstream changes to aws ccm e2e tests.

Summary by CodeRabbit

  • Documentation
    • Adjusted formatting in the README's operator status section.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Warning

Rate limit exceeded

@mfbonfigli has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 46 minutes and 26 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c8e228f3-6c3f-4d33-a60c-02bda05c3143

📥 Commits

Reviewing files that changed from the base of the PR and between 39297d2 and 05ac12b.

⛔ Files ignored due to path filters (33)
  • openshift-tests/ccm-aws-tests/go.sum is excluded by !**/*.sum
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/aws/go_module_metadata.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/CHANGELOG.md is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/go_module_metadata.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/CHANGELOG.md is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/go_module_metadata.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/CHANGELOG.md is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AllocateIpamPoolCidr.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_DescribeInstanceTypes.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_DescribeIpamPoolAllocations.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_DescribeIpamPools.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_DescribeIpamScopes.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_DescribeIpams.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_GetIpamPoolCidrs.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_GetIpamResourceCidrs.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_ModifyIpamPoolAllocation.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_ModifyManagedResourceVisibility.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_ModifyVpnConnectionOptions.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/deserializers.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/generated.json is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/go_module_metadata.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/serializers.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/types/enums.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/types/types.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/validators.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding/CHANGELOG.md is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding/go_module_metadata.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/internal/presigned-url/CHANGELOG.md is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/aws-sdk-go-v2/service/internal/presigned-url/go_module_metadata.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/smithy-go/CHANGELOG.md is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/github.com/aws/smithy-go/go_module_metadata.go is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/k8s.io/cloud-provider-aws/tests/e2e/LICENSE is excluded by !**/vendor/**
  • openshift-tests/ccm-aws-tests/vendor/modules.txt is excluded by !**/vendor/**
📒 Files selected for processing (1)
  • openshift-tests/ccm-aws-tests/go.mod

Walkthrough

The README.md file received a formatting adjustment to the placement of the "### Operator Status" subheading at line 9. No content was modified; only the whitespace or line positioning was changed.

Changes

README Structure

Layer / File(s) Summary
Operator Status heading placement
README.md
The "### Operator Status" subheading was repositioned at line 9 as a formatting adjustment with no surrounding content changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • racheljpg
  • theobarberbany

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 2 warnings)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❌ Error Found dynamic test name in openshift-tests/ccm-aws-tests/e2e/aws/loadbalancer.go line 46 using fmt.Sprintf to construct Describe title, violating stable/deterministic requirement. Replace fmt.Sprintf with static literal string in Describe() call at line 46 of loadbalancer.go.
Microshift Test Compatibility ⚠️ Warning New e2e tests use config.openshift.io FeatureGate API unavailable on MicroShift, lacking [apigroup:], [Skipped:MicroShift], or IsMicroShiftCluster() protections. Add [apigroup:config.openshift.io] to test name or [Skipped:MicroShift] label, or guard with IsMicroShiftCluster() check and g.Skip().
Single Node Openshift (Sno) Test Compatibility ⚠️ Warning New e2e tests validate LB target count equals nodeCount without SNO protection mechanisms like [Skipped:SingleReplicaTopology] or IsSingleNode() guards required for multi-node assumptions. Add [Skipped:SingleReplicaTopology] labels to tests that validate nodeCount-based assertions or wrap tests with exutil.IsSingleNode() checks to skip on SNO deployments.
✅ Passed checks (9 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the pull request's purpose as a DNM (Do Not Merge) test for CI validation of upstream e2e test changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Structure And Quality ✅ Passed AWS e2e tests meet quality criteria: 6 single-responsibility tests with explicit assertion messages, DeferCleanup for resource cleanup, BeforeEach setup, and Eventually calls with timeouts.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies vendored E2E test code and README; no deployment manifests, operator code, or controllers are added/modified, so topology-aware scheduling check does not apply.
Ote Binary Stdout Contract ✅ Passed No OTE Binary Stdout Contract violations detected. Changes are in vendored test files and README.md, with no stdout writes in process-level code (main, init, TestMain, BeforeSuite, etc.).
Ipv6 And Disconnected Network Test Compatibility ✅ Passed New Ginkgo e2e tests in loadbalancer.go have no hardcoded IPv4, external connectivity requirements, or IPv4-specific assumptions that would fail in IPv6-only disconnected environments.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nrb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfbonfigli
Copy link
Copy Markdown
Contributor Author

/testwith openshift/cloud-provider-aws/main/e2e-aws-ovn-techpreview openshift/cloud-provider-aws#153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant