Debug usage of self-hosted runner#4117
Open
gkoscins wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the reusable precommit workflow to run the pytorch-cuda job on a self-hosted runner group and inside an Ubuntu 22.04 container (including on-the-fly CUDA toolkit installation), apparently to help debug self-hosted runner usage.
Changes:
- Switch
pytorch-cudatoruns-on: { group, labels }and add a job container with GPU docker options and certificate-related environment variables. - Add container-side dependency installation and CUDA download/install steps.
- Comment out all non-CUDA jobs (
common,onnx,openvino,tools,pytorch-cpu), leaving onlypytorch-cuda, and downgrade several GitHub Action pins in this workflow.
Comments suppressed due to low confidence (1)
.github/workflows/call_precommit.yml:186
- This job runs inside an
ubuntu:22.04container, but the CUDA install step still usessudo. The base Ubuntu image typically does not includesudo, and the container runs as root by default, so this will fail at runtime.
run: |
wget -q https://developer.download.nvidia.com/compute/cuda/12.6.3/local_installers/cuda_12.6.3_560.35.05_linux.run
sudo sh cuda_12.6.3_560.35.05_linux.run --toolkit --silent
Comment on lines
+22
to
+27
| # common: | ||
| # timeout-minutes: 40 | ||
| # runs-on: ubuntu-latest | ||
| # defaults: | ||
| # run: | ||
| # shell: bash |
Comment on lines
192
to
196
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| lfs: true | ||
| - uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0 | ||
| - uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0 | ||
| with: |
Comment on lines
+198
to
+199
| - name: Install uv | ||
| uses: astral-sh/setup-uv@fac544c07dec837d0ccb6301d7b5580bf5edae39 # v8.2.0 | ||
| uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.