[ci] Avoid downloading model on collection test cases#4118
Open
AlexanderDokuchaev wants to merge 2 commits into
Open
[ci] Avoid downloading model on collection test cases#4118AlexanderDokuchaev wants to merge 2 commits into
AlexanderDokuchaev wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Torch dataset generator tests to avoid downloading Hugging Face models/tokenizers during pytest test collection by deferring model/tokenizer loading into the test body.
Changes:
- Refactors
test_generate_text_data_usageto parametrize by booleans and instantiate model/tokenizer inside the test. - Replaces the previous try/except validation with
pytest.raises(...)for clearer error expectations. - Adds stable parametrization IDs for easier debugging of failing cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Update test
test_generate_text_data_usageto load model inside test bodyReason for changes
Loading model on collection test cases
Related tickets
Tests