refactor: speedup int8 resize#172
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors ResizePreprocessor to avoid converting uint8 images to float32 before resizing, improving CPU resize performance for the common camera-output dtype while preserving the existing float32 output contract.
Changes:
- Keep
uint8inputs asuint8through resize/padding, and normalize tofloat32only at the end. - Switch the internal resize helper to operate on BHWC (channels-last) to better match OpenCV’s expected layout and reduce transposes.
- Add a unit test asserting
uint8resize matchesfloat32resize within quantization error.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/physicalai/inference/preprocessors/resize.py | Refactors resize path to operate in BHWC and delay uint8 normalization until after resize/pad. |
| tests/unit/inference/preprocessors/test_resize.py | Adds coverage comparing uint8 vs float32 resize outputs for equivalence within quantization error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alfieroddan
approved these changes
Jun 29, 2026
alfieroddan
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
Only edge case I can think of Depth images may wish to resize in different modes other than cv2.INTER_LINEAR but can save for a different PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Results on 2x 1920x1080
Validation
Breaking changes