wifi: mt76: pass LED define via ccflags-y in driver submodules - #1090
wifi: mt76: pass LED define via ccflags-y in driver submodules#1090mbc07 wants to merge 1 commit into
Conversation
Commit d2b01fb ("mt76: pass LED define via ccflags-y") converted the top-level Makefile from the deprecated EXTRA_CFLAGS to ccflags-y so that -DCONFIG_MT76_LEDS keeps working now that kbuild no longer honours EXTRA_CFLAGS. However, ccflags-y (like EXTRA_CFLAGS before it) only applies to the kbuild makefile it is set in and is not inherited by subdirectories pulled in via obj-y/obj-m. The mt7603, mt7615 and mt7915 driver subdirectories each set their own "EXTRA_CFLAGS += ... -DCONFIG_MT76_LEDS", which is now a silent no-op. As a result CONFIG_MT76_LEDS is undefined when building mt7603/init.c, mt7615/init.c, mt7615/pci_init.c and mt7915/init.c, the IS_ENABLED(CONFIG_MT76_LEDS) blocks are compiled out, and the mt76-* LED class devices are never registered for these drivers. Convert these subdirectory Makefiles to ccflags-y as well. mt7996/Makefile never carried the define at all, even though mt7996/init.c has the same IS_ENABLED(CONFIG_MT76_LEDS) checks for its LED callbacks and GPIO mux setup. Add ccflags-y there too so mt7996 LED support is enabled consistently with the other drivers. mt76x0, mt76x2, mt7921 and mt7925 contain no CONFIG_MT76_LEDS references and are left untouched. Fixes: d2b01fb ("mt76: pass LED define via ccflags-y") Link: openwrt#1077 Signed-off-by: Mateus B. Cassiano <mbc07@live.com>
|
Hi @nbd168, sorry for the ping — I just wanted to kindly ask what would be the best way to get this patch reviewed. The change is very small and self-contained, and I’ve tested it properly on my side. I also confirmed that it fixes the open issue linked in the PR (#1077). I'm under the impression this repository might follow a different review flow, but it's unclear to me what the next steps are, so I’d really appreciate any guidance on whether this can be reviewed here on GitHub or if there’s a preferred way I should resubmit it. Thanks a lot! |
|
Patch submitted to the Linux mailing list: https://lore.kernel.org/linux-wireless/20260715044431.1207-2-mbc07@live.com/T/#u Closing this PR now... |
|
I see you closed this one, but I can confirm it is working for mt7996: https://forum.banana-pi.org/t/bpi-r4-mt7996-be14-per-band-wifi-7-leds-now-work-incl-mlo/27574/11?u=avbohemen |
2 participants
This PR fixes #1077.
Completes the EXTRA_CFLAGS → ccflags-y migration for
-DCONFIG_MT76_LEDSthat was started in d2b01fb. That commit only touched the top-levelMakefile, butccflags-y/EXTRA_CFLAGSare scoped per kbuild makefile and aren't inherited by subdirectories.I tested this by compiling openwrt/openwrt@e4c35c2 with those changes for my D-Link DIR-882 A1 (has dual MT7615 radios); the
mt76-*LED class devices now correctly appear under/sys/class/leds, the same behavior reported earlier in #1077 (comment) with a different router (but also using MT7615 radios).The
mt7603,mt7915andmt7996changes are the same fix applied for consistency, but I don't have hardware to test those.mt7996in particular enables anIS_ENABLED(CONFIG_MT76_LEDS)code path that appears to have never been built with the define on before, so it'd be good if someone with that hardware could confirm it doesn't regress anything before merging. Alternatively, I can also drop themt7996change from this PR and leave only the others...